Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyEpsilon: fix version numbering #47546

Merged
merged 2 commits into from Oct 1, 2018
Merged

EmptyEpsilon: fix version numbering #47546

merged 2 commits into from Oct 1, 2018

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Sep 30, 2018 •
edited

Motivation for this change

Previous scheme produced incompatible versions for multiplayer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 3ac175e into NixOS:master Oct 1, 2018
globin pushed a commit to mayflower/nixpkgs that referenced this pull request Dec 15, 2018
@globin
EmptyEpsilon: fix version numbering (NixOS#47546)
cd61ccb 
(cherry picked from commit 3ac175e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nek0 @Mic92 @GrahamcOfBorg