Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.11.3 -> 1.12.0 #47560

Merged
merged 1 commit into from Sep 30, 2018
Merged

kubernetes: 1.11.3 -> 1.12.0 #47560

merged 1 commit into from Sep 30, 2018

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Sep 30, 2018

Kubelet CAdvisor port has been removed in kubernetes 1.12, thus the cadvisorPort option has been removed from the kubernetes module accordingly.

Motivation for this change

Bump kubernetes major version to 1.12

Things done

The following NixOS tests checks out clean:

/nixos/tests/kubernetes/rbac.nix
/nixos/tests/kubernetes/dns.nix

Real cluster testing has been performed on a 3 node, 3 master vmware cluster.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

kubernetes: 1.11.3 -> 1.12.0
a91c293 
- kubelet CAdvisor port has been removed
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kubernetes

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v4j3dj2x2bln0qrgvip6vyxg7aw1047v-kubernetes-1.12.0-man
checking for references to /build in /nix/store/v4j3dj2x2bln0qrgvip6vyxg7aw1047v-kubernetes-1.12.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/96hd5zhzd4r1sfnmlw763bkff84mn0dk-kubernetes-1.12.0-pause
shrinking /nix/store/96hd5zhzd4r1sfnmlw763bkff84mn0dk-kubernetes-1.12.0-pause/bin/pause
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/96hd5zhzd4r1sfnmlw763bkff84mn0dk-kubernetes-1.12.0-pause/bin
patching script interpreter paths in /nix/store/96hd5zhzd4r1sfnmlw763bkff84mn0dk-kubernetes-1.12.0-pause
checking for references to /build in /nix/store/96hd5zhzd4r1sfnmlw763bkff84mn0dk-kubernetes-1.12.0-pause...
/nix/store/q2zim1ysf53kdcpdl5f1f2x86bdasw8m-kubernetes-1.12.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kubernetes

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b5kg9wngkxsi4lygrjpx0qd9jknm688z-kubernetes-1.12.0-man
checking for references to /build in /nix/store/b5kg9wngkxsi4lygrjpx0qd9jknm688z-kubernetes-1.12.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/svia3ykis7bpbkb0rqvl6hrlwhjkmvrk-kubernetes-1.12.0-pause
shrinking /nix/store/svia3ykis7bpbkb0rqvl6hrlwhjkmvrk-kubernetes-1.12.0-pause/bin/pause
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/svia3ykis7bpbkb0rqvl6hrlwhjkmvrk-kubernetes-1.12.0-pause/bin
patching script interpreter paths in /nix/store/svia3ykis7bpbkb0rqvl6hrlwhjkmvrk-kubernetes-1.12.0-pause
checking for references to /build in /nix/store/svia3ykis7bpbkb0rqvl6hrlwhjkmvrk-kubernetes-1.12.0-pause...
/nix/store/wlf9kh08c3w07lb6wc7wnymazdllyzxd-kubernetes-1.12.0

@johanot
Copy link
Contributor Author

johanot commented Sep 30, 2018

@GrahamcOfBorg test kubernetes.rbac.singlenode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.dns.multinode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode

Partial log (click to expand)


Cannot nix-instantiate `tests.kubernetes.dns.singlenode' because:
error: attribute 'singlenode' in selection path 'tests.kubernetes.dns.singlenode' not found

Cannot nix-instantiate `tests.kubernetes.rbac.multinode' because:
error: attribute 'multinode' in selection path 'tests.kubernetes.rbac.multinode' not found

Cannot nix-instantiate `tests.kubernetes.dns.multinode' because:
error: attribute 'multinode' in selection path 'tests.kubernetes.dns.multinode' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode

Partial log (click to expand)

machine1: exit status 0
test script finished in 53.45s
cleaning up
killing machine1 (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ypcg1p3np2zmfch9qawsylk3sxmvpn7r-vm-test-run-kubernetes-rbac-singlenode
/nix/store/l5la0p7f542s6vjzvidahavz9is5yf7g-vm-test-run-kubernetes-dns-singlenode
/nix/store/p909aisgvpx1cwa9d2rp9f4yq2qx0brx-vm-test-run-kubernetes-rbac-multinode
/nix/store/zniicgb0z8mxdsjm64nycz31zczkq5ys-vm-test-run-kubernetes-dns-multinode

@srhb srhb merged commit a2e00df into NixOS:master Sep 30, 2018
@johanot johanot deleted the kubernetes-1.12 branch October 1, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @GrahamcOfBorg @srhb