Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omegat: init at 4.1.5.2 #47559

Merged
merged 1 commit into from Oct 15, 2018
Merged

omegat: init at 4.1.5.2 #47559

merged 1 commit into from Oct 15, 2018

Conversation

t184256
Copy link
Contributor

@t184256 t184256 commented Sep 30, 2018

OmegaT is a Computer-Assisted Translation tool written in Java.
This derivation doesn't build it from source, but rather downloads
a 'Cross-platform without JRE' zip file.
I took the liberty of shorting the upstream version naming of
"4.1.5 update 2 Beta" to a more concise "4.1.5.2".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Oct 14, 2018
View reviewed changes
pkgs/applications/misc/omegat.nix Outdated Show resolved Hide resolved
@t184256
omegat: init at 4.1.5.2
9835631 
OmegaT is a Computer-Assisted Translation tool written in Java.
This derivation doesn't build it from source, but rather downloads
a 'Cross-platform without JRE' zip file.
I took the liberty of shorting the upstream version naming of
"4.1.5 update 2 Beta" to a more concise "4.1.5.2".
@t184256
Copy link
Contributor Author

t184256 commented Oct 15, 2018

Why is it still marked as 'requested changes'?

infinisil
infinisil approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These reviews are done manually, I just didn't look at it again

Looks good now :)

@infinisil infinisil merged commit 67a99a8 into NixOS:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t184256 @infinisil @GrahamcOfBorg