Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses #47561

Merged
merged 9 commits into from Sep 30, 2018
Merged

Add licenses #47561

merged 9 commits into from Sep 30, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Another round for #43716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apr, boringssl, cln, cmark, cogl, ctpl, ctpp2

Partial log (click to expand)

copying path '/nix/store/236kpq1wqmfl2f49kcs0gz4xgpb76qmi-gst-plugins-base-1.14.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/vbfkcxdrrvjdmcg0ls4aj8xhgr4psc4a-libXcomposite-0.4.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/n2rn98gw734myyp0vj5l95k26xxkkg11-cogl-1.22.2' from 'https://cache.nixos.org'...
/nix/store/vil8davknazkw3xg55gq4bmbz64g87cm-apr-1.6.5
/nix/store/biy1j99hdna3cxqn67cych7gig8q24dm-boringssl-2017-02-23
/nix/store/5qqnpvf3q6dvriclb5f7bbmpp64dsrfg-cln-1.3.4
/nix/store/70qa79a3jhg76rcsdln1lxd9138srmzr-cmark-0.28.3
/nix/store/n2rn98gw734myyp0vj5l95k26xxkkg11-cogl-1.22.2
/nix/store/dgszkdw86bx7sja7f4yzhii2c41xnrzq-ctpl-0.3.4
/nix/store/6dr1vlh1yjdkfsalb70gn45nl7lqysh8-ctpp2-2.8.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apr, boringssl, cln, cmark, cogl, ctpl, ctpp2

Partial log (click to expand)

copying path '/nix/store/xy9mfqbd622zwd3mqz70x44g8bijxy2s-gst-plugins-base-1.14.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/v936j09wfilxr67hm2jdxy3ng2hj48lv-libXrandr-1.5.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/4frbcshlx0d61k2m8s7a1hvpvfwr8lnx-cogl-1.22.2' from 'https://cache.nixos.org'...
/nix/store/sy5b1arj5j6lldhxbik4w4xf3l3r47s8-apr-1.6.5
/nix/store/mbdbkryay3zm8fimj15w05had8bjbk8a-boringssl-2017-02-23
/nix/store/bvqlvkyx0a0qv4b41ksypdcbv3zv58c7-cln-1.3.4
/nix/store/103h8zqablzpffswivx6msg8cq6lsw0q-cmark-0.28.3
/nix/store/4frbcshlx0d61k2m8s7a1hvpvfwr8lnx-cogl-1.22.2
/nix/store/harqlwrqsjr503pc53whx9s9zcym19vw-ctpl-0.3.4
/nix/store/drcib3v0s0hzjm5sz0vv1djklvd1ybkp-ctpp2-2.8.3

tomberek
tomberek approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@xeji xeji merged commit 78e244e into NixOS:master Sep 30, 2018
@markuskowa markuskowa deleted the licenses-18 branch October 3, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @GrahamcOfBorg @tomberek @xeji