Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.py-cpuinfo: Fix darwin build #47558

Merged
merged 1 commit into from Sep 30, 2018
Merged

pythonPackages.py-cpuinfo: Fix darwin build #47558

merged 1 commit into from Sep 30, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the darwin build of py-cpuinfo.
I couldn't figure out why the test doesn't run on darwin, but I tested the resulting cpuinfo script and it seems do work outside of the build environment

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

@GrahamcOfBorg build python27Packages.py-cpuinfo python36Packages.py-cpuinfo

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.py-cpuinfo, python36Packages.py-cpuinfo

Partial log (click to expand)

tests/test_parse_cpu_string.py ...                                       [ 91%]
tests/test_parse_errors.py ..                                            [ 92%]
tests/test_pcbsd_10_x86_64.py ...                                        [ 94%]
tests/test_solaris_11_x86_32.py ...                                      [ 95%]
tests/test_windows_10_x86_64.py ....                                     [ 97%]
tests/test_windows_8_x86_64.py ....                                      [100%]

============= 196 passed, 2 skipped, 2 deselected in 1.33 seconds ==============
/nix/store/l72pwkamqp6zqa00i7px1wvfdqdwk7nl-python2.7-py-cpuinfo-4.0.0
/nix/store/297jw93i5b8jwzxwpl70gcws5s3lvjmc-python3.6-py-cpuinfo-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.py-cpuinfo, python36Packages.py-cpuinfo

Partial log (click to expand)

tests/test_parse_cpu_string.py ...                                       [ 91%]
tests/test_parse_errors.py ..                                            [ 92%]
tests/test_pcbsd_10_x86_64.py ...                                        [ 94%]
tests/test_solaris_11_x86_32.py ...                                      [ 95%]
tests/test_windows_10_x86_64.py ....                                     [ 97%]
tests/test_windows_8_x86_64.py ....                                      [100%]

============= 196 passed, 2 skipped, 2 deselected in 0.91 seconds ==============
/nix/store/8sqf92zrzldyk363i71ym5x31gvxkgmj-python2.7-py-cpuinfo-4.0.0
/nix/store/vlq3wabzlp8xr0w56pi5xc73bh768rwm-python3.6-py-cpuinfo-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.py-cpuinfo, python36Packages.py-cpuinfo

Partial log (click to expand)

tests/test_parse_cpu_string.py ...                                       [ 91%]
tests/test_parse_errors.py ..                                            [ 92%]
tests/test_pcbsd_10_x86_64.py ...                                        [ 94%]
tests/test_solaris_11_x86_32.py ...                                      [ 95%]
tests/test_windows_10_x86_64.py ....                                     [ 97%]
tests/test_windows_8_x86_64.py ....                                      [100%]

============= 196 passed, 2 skipped, 2 deselected in 0.67 seconds ==============
/nix/store/ws2q7r50sscqwh2fq74p36icijfx9x4y-python2.7-py-cpuinfo-4.0.0
/nix/store/5nmy9krfiqy5dj0s8ar4pc6m0ddb77sb-python3.6-py-cpuinfo-4.0.0

@xeji xeji merged commit 49dcf7b into NixOS:master Sep 30, 2018
xeji pushed a commit that referenced this pull request Sep 30, 2018
@knedlsepp @xeji
pythonPackages.py-cpuinfo: Fix darwin build (#47558)
0f1911e 
(cherry picked from commit 49dcf7b)
@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

backported: 0f1911e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg