Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snipes: init at 20180930 #47551

Merged
merged 1 commit into from Oct 1, 2018
Merged

snipes: init at 20180930 #47551

merged 1 commit into from Oct 1, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

A true classic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: snipes

Partial log (click to expand)

building
build flags: -j64 -l64 SHELL=/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash
g++ -o snipes -Werror -Wall -Wextra -std=c++11 -I/nix/store/iqa762mnxq71fj2lw5j98h8xdk1palfr-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/iqa762mnxq71fj2lw5j98h8xdk1palfr-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/08c0inrfxf8l6pf7mx5aqrwnkqi6m9xy-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/iqa762mnxq71fj2lw5j98h8xdk1palfr-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/08c0inrfxf8l6pf7mx5aqrwnkqi6m9xy-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -O3 Snipes.cpp sdl/console.cpp sdl/keyboard.cpp sdl/sound.cpp sdl/timer.cpp -L/nix/store/pyvf271y923h7xjhymb1cpp24xzsjx16-SDL2-2.0.8/lib -Wl,-rpath,/nix/store/pyvf271y923h7xjhymb1cpp24xzsjx16-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lm -lSDL2_ttf
Snipes.cpp:2121:40: error: '__cdecl__' attribute directive ignored [-Werror=attributes]
 int __cdecl main(int argc, char* argv[])
                                        ^
cc1plus: all warnings being treated as errors
make: *** [GNUmakefile:10: snipes] Error 1
builder for '/nix/store/71g7hij1bjs66v9y08bm2v3ngsxyb61n-snipes-20171208.drv' failed with exit code 2
error: build of '/nix/store/71g7hij1bjs66v9y08bm2v3ngsxyb61n-snipes-20171208.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: snipes

Partial log (click to expand)

g++ -o snipes -Werror -Wall -Wextra -std=c++11 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/7fjrpl1ghlkkbbnr0dfnv5nmv1k98k99-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/7fjrpl1ghlkkbbnr0dfnv5nmv1k98k99-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -O3 Snipes.cpp sdl/console.cpp sdl/keyboard.cpp sdl/sound.cpp sdl/timer.cpp -L/nix/store/8fkp6cyvaam9ghw1c1l910xry7yipqv7-SDL2-2.0.8/lib -Wl,-rpath,/nix/store/8fkp6cyvaam9ghw1c1l910xry7yipqv7-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lm -lSDL2_ttf
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208
shrinking /nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208/bin/snipes
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208/bin
patching script interpreter paths in /nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208
checking for references to /build in /nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208...
/nix/store/j831n60hv0pc8m27y3pcx64kkhx28689-snipes-20171208

@xeji
Copy link
Contributor

xeji commented Sep 30, 2018 •
edited

I get this:

$ nix-shell -p snipes

[nix-shell:~/nixpkgs]$ snipes
Assertion 'pa_atomic_dec(&f->data->waiting) >= 1' failed at pulsecore/fdsem.c:312, function pa_fdsem_after_poll(). Aborting.
Aborted

Edit: nevermind, it works when installed with nix-env.

xeji
xeji approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@peterhoeg
Copy link
Member Author

Edit: nevermind, it works when installed with nix-env.

Doing nix-build -A snipes $(pwd) && result/bin/snipes works for me.

FYI, the new commit just pushed should fix the arm build.

@peterhoeg peterhoeg changed the title snipes: init at 20171208 snipes: init at 20180930 Oct 1, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: snipes

Partial log (click to expand)

                                        ^
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930
shrinking /nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930/bin/snipes
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930/bin
patching script interpreter paths in /nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930
checking for references to /build in /nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930...
/nix/store/32naqwds17facx1j9p9m8aq81462r6ah-snipes-20180930

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: snipes

Partial log (click to expand)

g++ -o snipes -Wall -Wextra -std=c++11 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/7fjrpl1ghlkkbbnr0dfnv5nmv1k98k99-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/l2jri8yzrxrxf3v3wqf4bbr4xppczc7x-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/7fjrpl1ghlkkbbnr0dfnv5nmv1k98k99-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -O3 Snipes.cpp sdl/console.cpp sdl/keyboard.cpp sdl/sound.cpp sdl/timer.cpp -L/nix/store/8fkp6cyvaam9ghw1c1l910xry7yipqv7-SDL2-2.0.8/lib -Wl,-rpath,/nix/store/8fkp6cyvaam9ghw1c1l910xry7yipqv7-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lm -lSDL2_ttf
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930
shrinking /nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930/bin/snipes
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930/bin
patching script interpreter paths in /nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930
checking for references to /build in /nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930...
/nix/store/pivvmf7603ka4cfw34f9sf0zzdsryprp-snipes-20180930

@peterhoeg peterhoeg merged commit f8e758a into NixOS:master Oct 1, 2018
@peterhoeg peterhoeg deleted the p/snipes branch October 1, 2018 02:26
@peterhoeg peterhoeg restored the p/snipes branch October 1, 2018 06:58
@peterhoeg peterhoeg deleted the p/snipes branch October 1, 2018 09:07
@peterhoeg peterhoeg restored the p/snipes branch October 1, 2018 09:20
@peterhoeg peterhoeg deleted the p/snipes branch October 8, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @xeji