Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperfine: 1.1.0 -> 1.3.0 #47521

Merged
merged 1 commit into from Oct 2, 2018
Merged

hyperfine: 1.1.0 -> 1.3.0 #47521

merged 1 commit into from Oct 2, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @thoughtpolice

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0
shrinking /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0
checking for references to /build in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0...
/nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0
shrinking /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0
checking for references to /build in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0...
/nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0

@tomberek
Copy link
Contributor

Failed on Ubuntu with error below. Works fine on NixOS:

...
  Compiling unreachable v1.0.0
   Compiling regex-syntax v0.6.2
   Compiling regex-syntax v0.5.6
error: failed to run custom build command for `num-traits v0.2.6`                                                  
could not execute process `/run/nix/nix-build-hyperfine-1.3.0.drv-0/source/target/release/build/num-traits-0bcee0243813104a/build-script-build` (never executed)
warning: build failed, waiting for other jobs to finish...

@dywedir
Copy link
Member Author

dywedir commented Sep 30, 2018

That's odd. Could you please provide some logs?

@tomberek
Copy link
Contributor

Looks like a temporary issue with fetching. Works okay now.

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

let's build again here to make sure
@GrahamcOfBorg build hyperfine

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0
shrinking /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0
checking for references to /build in /nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0...
/nix/store/0wzk77fn0jhng0dg1qm47dgrj060d1br-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0
shrinking /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0
checking for references to /build in /nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0...
/nix/store/yiin8pw2jdcycvik208jbd96iccllpzh-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: hyperfine

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `hyperfine`.

To learn more, run the command again with --verbose.
builder for '/nix/store/qn4izjnsjsxvw3a5i5dinzrw9d0imh85-hyperfine-1.3.0.drv' failed with exit code 101
error: build of '/nix/store/qn4izjnsjsxvw3a5i5dinzrw9d0imh85-hyperfine-1.3.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

Darwin failure is a regression , current version builds. Looks like Security framework is missing.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0
shrinking /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0
checking for references to /build in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0...
/nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0
shrinking /nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0
checking for references to /build in /nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0...
/nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0

@xeji
Copy link
Contributor

xeji commented Oct 2, 2018

let's try darwin
@GrahamcOfBorg build hyperfine

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)

/nix/store/l6akzd1spgbch7rfyfq4dz5l0991mafi-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: hyperfine

Partial log (click to expand)

test hyperfine::outlier_detection::test_detect_outliers ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y1rvpmzipmymb3n9smkvd3av23crc99v-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/y1rvpmzipmymb3n9smkvd3av23crc99v-hyperfine-1.3.0
/nix/store/y1rvpmzipmymb3n9smkvd3av23crc99v-hyperfine-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hyperfine

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0
shrinking /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0/bin/hyperfine
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0/bin
patching script interpreter paths in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0
checking for references to /build in /nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0...
/nix/store/m4w9i98j47qadvl1q3li9ykf6nk8b17b-hyperfine-1.3.0

@xeji xeji merged commit bae2f2d into NixOS:master Oct 2, 2018
@dywedir dywedir deleted the hyperfine branch October 2, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @GrahamcOfBorg @tomberek @xeji