Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lz4: 1.8.2 -> 1.8.3 #47547

Merged
merged 1 commit into from Oct 1, 2018
Merged

lz4: 1.8.2 -> 1.8.3 #47547

merged 1 commit into from Oct 1, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 30, 2018 •
edited

Upstream release notes, quickfix release for corruption bug

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: lz4

Partial log (click to expand)

post-installation fixup
Patching '/nix/store/g4468haap38gkfwrspmm9bccvvhbhlgp-lz4-1.8.3-dev/lib/pkgconfig/liblz4.pc' includedir to output /nix/store/g4468haap38gkfwrspmm9bccvvhbhlgp-lz4-1.8.3-dev
gzipping man pages under /nix/store/r4vqqbnh8sk3g0r5rm8gakp26sfzfgri-lz4-1.8.3/share/man/
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/r4vqqbnh8sk3g0r5rm8gakp26sfzfgri-lz4-1.8.3/lib  /nix/store/r4vqqbnh8sk3g0r5rm8gakp26sfzfgri-lz4-1.8.3/bin
patching script interpreter paths in /nix/store/r4vqqbnh8sk3g0r5rm8gakp26sfzfgri-lz4-1.8.3
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/g4468haap38gkfwrspmm9bccvvhbhlgp-lz4-1.8.3-dev/lib
patching script interpreter paths in /nix/store/g4468haap38gkfwrspmm9bccvvhbhlgp-lz4-1.8.3-dev
/nix/store/r4vqqbnh8sk3g0r5rm8gakp26sfzfgri-lz4-1.8.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9jahmqrr2dx3x7fn52hll3bgsy51rv4-lz4-1.8.3/lib  /nix/store/l9jahmqrr2dx3x7fn52hll3bgsy51rv4-lz4-1.8.3/bin
patching script interpreter paths in /nix/store/l9jahmqrr2dx3x7fn52hll3bgsy51rv4-lz4-1.8.3
checking for references to /build in /nix/store/l9jahmqrr2dx3x7fn52hll3bgsy51rv4-lz4-1.8.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/pzz2vc0kg7k97465hgvviycnkm582a4q-lz4-1.8.3-dev
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pzz2vc0kg7k97465hgvviycnkm582a4q-lz4-1.8.3-dev/lib
patching script interpreter paths in /nix/store/pzz2vc0kg7k97465hgvviycnkm582a4q-lz4-1.8.3-dev
checking for references to /build in /nix/store/pzz2vc0kg7k97465hgvviycnkm582a4q-lz4-1.8.3-dev...
/nix/store/l9jahmqrr2dx3x7fn52hll3bgsy51rv4-lz4-1.8.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z1z4wjx5lcpjz8k49602dqlmkh2j89sa-lz4-1.8.3/lib  /nix/store/z1z4wjx5lcpjz8k49602dqlmkh2j89sa-lz4-1.8.3/bin
patching script interpreter paths in /nix/store/z1z4wjx5lcpjz8k49602dqlmkh2j89sa-lz4-1.8.3
checking for references to /build in /nix/store/z1z4wjx5lcpjz8k49602dqlmkh2j89sa-lz4-1.8.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/p6kbarwy7lha9sngd5w24cw6i8k250lz-lz4-1.8.3-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p6kbarwy7lha9sngd5w24cw6i8k250lz-lz4-1.8.3-dev/lib
patching script interpreter paths in /nix/store/p6kbarwy7lha9sngd5w24cw6i8k250lz-lz4-1.8.3-dev
checking for references to /build in /nix/store/p6kbarwy7lha9sngd5w24cw6i8k250lz-lz4-1.8.3-dev...
/nix/store/z1z4wjx5lcpjz8k49602dqlmkh2j89sa-lz4-1.8.3

@dtzWill
Copy link
Member Author

dtzWill commented Sep 30, 2018

Time to do the "move to staging" dance and tag everyone for no reason because "github" ;(.

/me starts dancing

@dtzWill dtzWill changed the base branch from master to staging September 30, 2018 05:12
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a05pa9n714yf9wdwynhyl05gnl46y59d-lz4-1.8.3/lib  /nix/store/a05pa9n714yf9wdwynhyl05gnl46y59d-lz4-1.8.3/bin
patching script interpreter paths in /nix/store/a05pa9n714yf9wdwynhyl05gnl46y59d-lz4-1.8.3
checking for references to /build in /nix/store/a05pa9n714yf9wdwynhyl05gnl46y59d-lz4-1.8.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/bg29f398k2h62jny631b03v5qvyw5lxy-lz4-1.8.3-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bg29f398k2h62jny631b03v5qvyw5lxy-lz4-1.8.3-dev/lib
patching script interpreter paths in /nix/store/bg29f398k2h62jny631b03v5qvyw5lxy-lz4-1.8.3-dev
checking for references to /build in /nix/store/bg29f398k2h62jny631b03v5qvyw5lxy-lz4-1.8.3-dev...
/nix/store/a05pa9n714yf9wdwynhyl05gnl46y59d-lz4-1.8.3

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: lz4

Partial log (click to expand)

cannot build derivation '/nix/store/6y4kz2cszr206y4c0g2f6j8shnwdw62b-perl-5.28.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/x4vkib8a9pdr5ws23zz5nkgbx2j64a4n-pkg-config-0.29.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ynmxpnvbzw3zdmkddq615bg5zac1amcy-unzip-6.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/kzx3rmxp28kdf1wxpiqikmjwc9clnfvx-openssl-1.0.2p.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/mi69karlwrj6nvll82cq0lra0riv8hr3-libssh2-1.8.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/7slh3201sgzm3czr7bv67j1fvkv929xg-nghttp2-1.32.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/3hgark3b9md8vs9w72n3y9nxlg5xlqix-curl-7.61.1.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/1gjyajh201677rqiaigqaz33h0rmgr79-source.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/v54k9lp53gsg2jkdslh8mxaqaik1qqha-lz4-1.8.3.drv': 3 dependencies couldn't be built
error: build of '/nix/store/v54k9lp53gsg2jkdslh8mxaqaik1qqha-lz4-1.8.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lz4

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zkv7knyzwv4y8aggm4qr8r3x8wvgfvxw-lz4-1.8.3/lib  /nix/store/zkv7knyzwv4y8aggm4qr8r3x8wvgfvxw-lz4-1.8.3/bin
patching script interpreter paths in /nix/store/zkv7knyzwv4y8aggm4qr8r3x8wvgfvxw-lz4-1.8.3
checking for references to /build in /nix/store/zkv7knyzwv4y8aggm4qr8r3x8wvgfvxw-lz4-1.8.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/szcqi6g285h13iwynp1crhiq9xjf4zrq-lz4-1.8.3-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/szcqi6g285h13iwynp1crhiq9xjf4zrq-lz4-1.8.3-dev/lib
patching script interpreter paths in /nix/store/szcqi6g285h13iwynp1crhiq9xjf4zrq-lz4-1.8.3-dev
checking for references to /build in /nix/store/szcqi6g285h13iwynp1crhiq9xjf4zrq-lz4-1.8.3-dev...
/nix/store/zkv7knyzwv4y8aggm4qr8r3x8wvgfvxw-lz4-1.8.3

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2018 •
edited

The release notes strongly recommends to backport this. So please also backport to staging-18.09

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

@dtzWill : nice dance 👍

@xeji xeji merged commit 55b6cad into NixOS:staging Oct 1, 2018
xeji pushed a commit that referenced this pull request Oct 1, 2018
@dtzWill @xeji
lz4: 1.8.2 -> 1.8.3 (#47547)
1f1c807 
(cherry picked from commit 55b6cad)
@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

picked to staging-18.09: 1f1c807

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Oct 11, 2018
@dtzWill
lz4: 1.8.2 -> 1.8.3 (NixOS#47547)
49f04d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 6.topic: rust 6.topic: stdenv Standard environment 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @Mic92 @xeji