Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard-tools: Fix build #47520

Merged
merged 1 commit into from Sep 29, 2018
Merged

wireguard-tools: Fix build #47520

merged 1 commit into from Sep 29, 2018

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

Fix the build. I'm not sure how the update bot has been updating this successfully - are we not running builds/smoke tests?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aneeshusa
Copy link
Contributor Author

cc maintainers @ericsagnes @Mic92 @zx2c4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wireguard-tools

Partial log (click to expand)

these paths will be fetched (0.05 MiB download, 0.12 MiB unpacked):
  /nix/store/6s9g4c6x91gxyk728g9vllc9z448f9wv-wireguard-tools-0.0.20180918
copying path '/nix/store/6s9g4c6x91gxyk728g9vllc9z448f9wv-wireguard-tools-0.0.20180918' from 'https://cache.nixos.org'...
/nix/store/6s9g4c6x91gxyk728g9vllc9z448f9wv-wireguard-tools-0.0.20180918

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: wireguard-tools

Partial log (click to expand)

these paths will be fetched (1.71 MiB download, 3.94 MiB unpacked):
  /nix/store/cf3b25aqgv8xkr838rqfhglpxmvwai0b-wireguard-go-0.0.20180613-bin
  /nix/store/jfckm5j12yglww2kbh1zv1xzb12is2kb-wireguard-tools-0.0.20180918
copying path '/nix/store/cf3b25aqgv8xkr838rqfhglpxmvwai0b-wireguard-go-0.0.20180613-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/jfckm5j12yglww2kbh1zv1xzb12is2kb-wireguard-tools-0.0.20180918' from 'https://cache.nixos.org'...
/nix/store/jfckm5j12yglww2kbh1zv1xzb12is2kb-wireguard-tools-0.0.20180918

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wireguard-tools

Partial log (click to expand)

these paths will be fetched (0.05 MiB download, 0.13 MiB unpacked):
  /nix/store/9zllp63j6kjxp0haj730vgnrzxd1iwgb-wireguard-tools-0.0.20180918
copying path '/nix/store/9zllp63j6kjxp0haj730vgnrzxd1iwgb-wireguard-tools-0.0.20180918' from 'https://cache.nixos.org'...
/nix/store/9zllp63j6kjxp0haj730vgnrzxd1iwgb-wireguard-tools-0.0.20180918

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

The wireguard build is not really broken as you can see here: https://hydra.nixos.org/build/81868965
as it also accept a list of list. However your solution is better

@Mic92 Mic92 merged commit dabdd7b into NixOS:master Sep 29, 2018
@aneeshusa aneeshusa deleted the wireguard-tools-fix-build branch January 7, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aneeshusa @GrahamcOfBorg @Mic92