light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper. #47554

dtzWill · 2018-09-30T12:11:12Z

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-09-30T12:26:07Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: light

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-30T12:26:15Z

Success on x86_64-linux (full log)

Attempted: light

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
shrinking /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin/light
gzipping man pages under /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/lib  /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin
patching script interpreter paths in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
checking for references to /build in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2...
/nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2

GrahamcOfBorg · 2018-09-30T12:26:17Z

Success on aarch64-linux (full log)

Attempted: light

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2
shrinking /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/bin/light
gzipping man pages under /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/lib  /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/bin
patching script interpreter paths in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2
checking for references to /build in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2...
/nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2

Mic92 · 2018-09-30T21:47:45Z

nixos/modules/programs/light.nix

        '';
      };
    };
  };

  config = mkIf cfg.enable {
    environment.systemPackages = [ pkgs.light ];
-    security.wrappers.light.source = "${pkgs.light.out}/bin/light";
+    services.udev.packages = [ pkgs.light ];


Do I need to be in a specific group for that?

Yes, updated the documentation comment to mention it. Not sure if there's a best practice for managing this sort of group, but personally I'm happy with "video" as a few projects default to it and I'm not sure there's much need to make this too customizable :). But willing to be convinced otherwise of course.

Ok. I added this to our release notes.

GrahamcOfBorg · 2018-10-01T02:33:16Z

Success on aarch64-linux (full log)

Attempted: light

Partial log (click to expand)

/nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2

GrahamcOfBorg · 2018-10-01T02:33:20Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: light

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-01T02:34:00Z

Success on x86_64-linux (full log)

Attempted: light

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
shrinking /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin/light
gzipping man pages under /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/lib  /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin
patching script interpreter paths in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
checking for references to /build in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2...
/nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2

GrahamcOfBorg · 2018-10-01T06:47:57Z

Success on aarch64-linux (full log)

Attempted: light

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2
shrinking /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/bin/light
gzipping man pages under /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/lib  /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2/bin
patching script interpreter paths in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2
checking for references to /build in /nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2...
/nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2

GrahamcOfBorg · 2018-10-01T06:48:04Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: light

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-01T06:48:06Z

Success on x86_64-linux (full log)

Attempted: light

Partial log (click to expand)

/nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2

dtzWill · 2018-10-01T09:26:57Z

Oh, good call! Thanks!!

Mic92 · 2018-10-01T13:07:41Z

nixos/doc/manual/release-notes/rl-1903.xml

@@ -105,6 +105,14 @@
     <varname>rabbitmq-server</varname>.
    </para>
   </listitem>
+   <listitem>
+     <para>
+       The <literal>light</literal> module no longer use setuids binary, but


typo I introduced: setuid binaries

GrahamcOfBorg · 2018-10-01T19:53:31Z

Success on aarch64-linux (full log)

Attempted: light

Partial log (click to expand)

/nix/store/dkcqb8rsxi7h2hv4biw193dhqqs02k2g-light-1.2

GrahamcOfBorg · 2018-10-01T19:53:54Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: light

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-01T19:54:24Z

Success on x86_64-linux (full log)

Attempted: light

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
shrinking /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin/light
gzipping man pages under /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/lib  /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2/bin
patching script interpreter paths in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2
checking for references to /build in /nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2...
/nix/store/4vkqhc211zy0bj4kmw2xl8r18qp4wnxz-light-1.2

dtzWill · 2018-10-04T20:08:17Z

This is good to go, I think? Just checking :).

Mic92 · 2018-10-04T21:35:36Z

I have not really tested it myself by adding myself to the group, but I suppose you did, so should be good to merge then.

dtzWill · 2018-10-06T04:15:41Z

Yep use it every day :).

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 30, 2018

Mic92 reviewed Sep 30, 2018

View reviewed changes

dtzWill added 2 commits September 30, 2018 21:15

light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper.

c78cda2

light: user needs to be in the 'video' group

5cc251d

dtzWill force-pushed the update/light-1.2 branch from 812b3f0 to 5cc251d Compare October 1, 2018 02:21

nixos/doc: mention light module change in release notes

6b68e6d

GrahamcOfBorg added 8.has: changelog 8.has: documentation labels Oct 1, 2018

Mic92 reviewed Oct 1, 2018

View reviewed changes

fix minor typo per reviewer feedback

7180706

dtzWill merged commit 003c20e into NixOS:master Oct 6, 2018

dtzWill deleted the update/light-1.2 branch October 6, 2018 04:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper. #47554

light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper. #47554

dtzWill commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

Mic92 Sep 30, 2018

dtzWill Oct 1, 2018

Mic92 Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

dtzWill commented Oct 1, 2018

Mic92 Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

dtzWill commented Oct 4, 2018

Mic92 commented Oct 4, 2018 •

edited

dtzWill commented Oct 6, 2018

light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper. #47554

light: 1.1.2 -> 1.2, use new udev support instead of setuid wrapper. #47554

Conversation

dtzWill commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

Mic92 Sep 30, 2018

Choose a reason for hiding this comment

dtzWill Oct 1, 2018

Choose a reason for hiding this comment

Mic92 Oct 1, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

dtzWill commented Oct 1, 2018

Mic92 Oct 1, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

dtzWill commented Oct 4, 2018

Mic92 commented Oct 4, 2018 • edited

dtzWill commented Oct 6, 2018

Mic92 commented Oct 4, 2018 •

edited