Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-mapnik: Fix build #47557

Merged
merged 2 commits into from Sep 30, 2018
Merged

python-mapnik: Fix build #47557

merged 2 commits into from Sep 30, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the python-mapnik build. cc #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@knedlsepp
mapnik: 3.0.13 -> 3.0.20
b1857da
@knedlsepp
pythonPackages.python-mapnik: Fix build
be6451e 
There were two things to fix:
- Boost started shipping libboost_python.so as libboost_python{Major}{Minor}
- Make sure that mapnik and boost link to the correct version of python.
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build python2Packages.python-mapnik python3Packages.python-mapnik

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mapnik

Partial log (click to expand)

Install file: "fonts/dejavu-fonts-ttf-2.37/ttf/DejaVuSerifCondensed-Italic.ttf" as "/nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20/lib/mapnik/fonts/DejaVuSerifCondensed-Italic.ttf"
Install file: "fonts/dejavu-fonts-ttf-2.37/ttf/DejaVuSerifCondensed.ttf" as "/nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20/lib/mapnik/fonts/DejaVuSerifCondensed.ttf"
scons: done building targets.
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20/lib  /nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20/bin
patching script interpreter paths in /nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20
/nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20/bin/mapnik-config: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/z2pc6bbx9d1mwwahnds31a7nlvjbi9zr-bash-4.4-p23/bin/bash"
/nix/store/rs1wbas1i545a3pv4ags23vkim923bmp-mapnik-3.0.20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mapnik

Partial log (click to expand)

shrinking /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/lib/mapnik/input/postgis.input
shrinking /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/lib/mapnik/input/sqlite.input
shrinking /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/lib/mapnik/input/raster.input
shrinking /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/lib/libmapnik.so.3.0.20
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/lib  /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/bin
patching script interpreter paths in /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20
/nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20/bin/mapnik-config: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20...
/nix/store/s0kn240lmvw1slf5hxfbwz5lbl16520x-mapnik-3.0.20

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.python-mapnik, python3Packages.python-mapnik

Partial log (click to expand)

Installing collected packages: mapnik
Successfully installed mapnik-0.1
/private/tmp/nix-build-python3.6-python-mapnik-3.0.16.drv-0/source
glibPreFixupPhase
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rp45vvv4im677k3lfh548qk2aiarqz6v-python3.6-python-mapnik-3.0.16/lib
patching script interpreter paths in /nix/store/rp45vvv4im677k3lfh548qk2aiarqz6v-python3.6-python-mapnik-3.0.16
/nix/store/q4zmw6s55932q6y39zn7axb79hip4izm-python2.7-python-mapnik-3.0.16
/nix/store/rp45vvv4im677k3lfh548qk2aiarqz6v-python3.6-python-mapnik-3.0.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mapnik

Partial log (click to expand)

shrinking /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/lib/mapnik/input/geojson.input
shrinking /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/lib/mapnik/input/gdal.input
shrinking /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/lib/mapnik/input/csv.input
shrinking /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/lib/libmapnik.so.3.0.20
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/lib  /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/bin
patching script interpreter paths in /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20
/nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20/bin/mapnik-config: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20...
/nix/store/s8kwjhw77hydj5pcwfv5x5akqnbxxqsp-mapnik-3.0.20

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.python-mapnik, python3Packages.python-mapnik

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16
shrinking /nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16/lib/python3.6/site-packages/mapnik/_mapnik.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16/lib
patching script interpreter paths in /nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16
checking for references to /build in /nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16...
/nix/store/kag9srg85j74m324hfv1fg0v72d59irx-python2.7-python-mapnik-3.0.16
/nix/store/7x8cpf1fgbsc9dr09bnax1b4plckjqlm-python3.6-python-mapnik-3.0.16

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: python2Packages.python-mapnik, python3Packages.python-mapnik

Partial log (click to expand)

plugins/input/topojson/topojson_datasource.cpp:174:0: warning: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result [-Wunused-result]
         std::fread(&file_buffer[0], file.size(), 1, file.get());

c++ -o plugins/input/topojson/topojson_featureset.os -c -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden -Wall -pthread -ftemplate-depth-300 -Wsign-compare -Wshadow -O3 -fPIC -DMAPNIK_MEMORY_MAPPED_FILE -DMAPNIK_HAS_DLCFN -DBIGINT -DBOOST_REGEX_HAS_ICU -DHAVE_JPEG -DMAPNIK_USE_PROJ4 -DHAVE_PNG -DHAVE_WEBP -DHAVE_TIFF -DLINUX -DMAPNIK_THREADSAFE -DBOOST_SPIRIT_NO_PREDEFINED_TERMINALS=1 -DBOOST_PHOENIX_NO_PREDEFINED_TERMINALS=1 -DBOOST_SPIRIT_USE_PHOENIX_V3=1 -DNDEBUG -Ideps -Ideps/mapbox/variant/include -Ideps/agg/include -Iinclude -I/nix/store/6d2bmjmzsxw3gy7pgaiisqggab77bygz-sqlite-3.24.0-dev/include -I/nix/store/7dj46v38p72n3aiklhbh94f4xrjrkdp0-icu4c-59.1-dev/include -I/nix/store/9fcfbnvcakgswg97s2c68p2awxhs2khp-harfbuzz-1.8.8-dev/include -I/nix/store/ay7h083ivv8dcw7l4x0w1xb85nxjhi55-freetype-2.9-dev/include -I/nix/store/psp7qlrkz6sgfiah8cw4n85ibhh18jjm-libjpeg-turbo-1.5.3-dev/include -I/nix/store/jyqah6h603gd2k2ila68sraprxy81d3j-proj-4.9.3/include -I/nix/store/fpigymkx8bn1mlz1klz0bl4fdgx597mv-libpng-apng-1.6.34-dev/include -I/nix/store/c7f0dg0ki7nq90jafh7b138hzc4calzp-libwebp-1.0.0/include -I/nix/store/rkv4idlsqc41b9csq7maafhw4njz56v3-libtiff-4.0.9-dev/include -I/nix/store/lxwan0p8rsswrzbqnxd82404n094dy2j-boost-1.67_0-dev/include -I/nix/store/893c9m5cx19x2b69f6xhxx6lmbsp79k5-postgresql-9.6.10/include -I/nix/store/c65gpsl7pqvc3nazjxj15lvq2iaf7axa-gdal-2.3.1/include plugins/input/topojson/topojson_featureset.cpp
c++ -o plugins/input/topojson/topojson_featureset.os -c -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden -Wall -pthread -ftemplate-depth-300 -Wsign-compare -Wshadow -O3 -fPIC -DMAPNIK_MEMORY_MAPPED_FILE -DMAPNIK_HAS_DLCFN -DBIGINT -DBOOST_REGEX_HAS_ICU -DHAVE_JPEG -DMAPNIK_USE_PROJ4 -DHAVE_PNG -DHAVE_WEBP -DHAVE_TIFF -DLINUX -DMAPNIK_THREADSAFE -DBOOST_SPIRIT_NO_PREDEFINED_TERMINALS=1 -DBOOST_PHOENIX_NO_PREDEFINED_TERMINALS=1 -DBOOST_SPIRIT_USE_PHOENIX_V3=1 -DNDEBUG -Ideps -Ideps/mapbox/variant/include -Ideps/agg/include -Iinclude -I/nix/store/6d2bmjmzsxw3gy7pgaiisqggab77bygz-sqlite-3.24.0-dev/include -I/nix/store/7dj46v38p72n3aiklhbh94f4xrjrkdp0-icu4c-59.1-dev/include -I/nix/store/9fcfbnvcakgswg97s2c68p2awxhs2khp-harfbuzz-1.8.8-dev/include -I/nix/store/ay7h083ivv8dcw7l4x0w1xb85nxjhi55-freetype-2.9-dev/include -I/nix/store/psp7qlrkz6sgfiah8cw4n85ibhh18jjm-libjpeg-turbo-1.5.3-dev/include -I/nix/store/jyqah6h603gd2k2ila68sraprxy81d3j-proj-4.9.3/include -I/nix/store/fpigymkx8bn1mlz1klz0bl4fdgx597mv-libpng-apng-1.6.34-dev/include -I/nix/store/c7f0dg0ki7nq90jafh7b138hzc4calzp-libwebp-1.0.0/include -I/nix/store/rkv4idlsqc41b9csq7maafhw4njz56v3-libtiff-4.0.9-dev/include -I/nix/store/p63si3sayqf9x34z3y5zrb2dkwrdf885-boost-1.67_0-dev/include -I/nix/store/893c9m5cx19x2b69f6xhxx6lmbsp79k5-postgresql-9.6.10/include -I/nix/store/c65gpsl7pqvc3nazjxj15lvq2iaf7axa-gdal-2.3.1/include plugins/input/topojson/topojson_featureset.cpp
building of '/nix/store/06da9gngjgb7wh87pzhd4cwvcgjbb2kh-mapnik-3.0.20.drv' timed out after 3600 seconds
building of '/nix/store/ayq370xsgs38754pnmyqlfj33f4cabsr-mapnik-3.0.20.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/kn52zgczqvpmm6fnh2is0767z8q1lasl-python2.7-python-mapnik-3.0.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v0ifz1xbrnpckmcr6vl854dyb41nv254-python3.6-python-mapnik-3.0.16.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kn52zgczqvpmm6fnh2is0767z8q1lasl-python2.7-python-mapnik-3.0.16.drv', '/nix/store/v0ifz1xbrnpckmcr6vl854dyb41nv254-python3.6-python-mapnik-3.0.16.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

Thank you!

@xeji xeji merged commit 339835b into NixOS:master Sep 30, 2018
@xeji
Copy link
Contributor

xeji commented Sep 30, 2018

backported in 26537f5..f2a1d99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @GrahamcOfBorg @xeji