Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig: 0.2.0 -> 0.3.0 #47534

Merged
merged 1 commit into from Sep 30, 2018
Merged

zig: 0.2.0 -> 0.3.0 #47534

merged 1 commit into from Sep 30, 2018

Conversation

andrewrk
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 29, 2018

@GrahamcOfBorg build zig

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zig

Partial log (click to expand)

-- Installing: /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/lib/zig/std/zig/parse_string_literal.zig
-- Installing: /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/lib/zig/std/zig/render.zig
-- Installing: /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/lib/zig/std/zig/tokenizer.zig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0
shrinking /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/bin/zig
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/lib  /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0/bin
patching script interpreter paths in /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0
checking for references to /build in /nix/store/89g92n05sdxcxj71w4b7lh7g0fr242m9-zig-0.3.0...

dtzWill
dtzWill approved these changes Sep 29, 2018
View reviewed changes
pkgs/development/compilers/zig/default.nix
preConfigure = ''
cmakeFlags="$cmakeFlags -DZIG_LIBC_STATIC_LIB_DIR=$(dirname $(cc -print-file-name=crtbegin.o)) -DZIG_DYNAMIC_LINKER=$(cc -print-file-name=ld-linux-x86-64.so.2)"
'';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are no longer needed? 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! This is a happy side-effect of Zig's static Linux binaries (which even work on NixOS). libc is detected at runtime.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zig

Partial log (click to expand)

-- Installing: /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/lib/zig/std/zig/parse_string_literal.zig
-- Installing: /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/lib/zig/std/zig/render.zig
-- Installing: /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/lib/zig/std/zig/tokenizer.zig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0
shrinking /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/bin/zig
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/lib  /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0/bin
patching script interpreter paths in /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0
checking for references to /build in /nix/store/6s62sfzz5746svzhjxljpk5wd5ag15p1-zig-0.3.0...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: zig

Partial log (click to expand)

[ 68%] Building CXX object lib/StaticAnalyzer/Checkers/CMakeFiles/clangStaticAnalyzerCheckers.dir/UndefResultChecker.cpp.o
[ 68%] Building CXX object tools/extra/clang-tidy/android/CMakeFiles/clangTidyAndroidModule.dir/CloexecFopenCheck.cpp.o
[ 68%] Building CXX object lib/StaticAnalyzer/Checkers/CMakeFiles/clangStaticAnalyzerCheckers.dir/UndefinedArraySubscriptChecker.cpp.o
[ 68%] Building CXX object tools/extra/clang-tidy/android/CMakeFiles/clangTidyAndroidModule.dir/CloexecInotifyInit1Check.cpp.o
[ 68%] Building CXX object lib/StaticAnalyzer/Checkers/CMakeFiles/clangStaticAnalyzerCheckers.dir/UndefinedAssignmentChecker.cpp.o
[ 68%] Building CXX object tools/extra/clang-tidy/android/CMakeFiles/clangTidyAndroidModule.dir/CloexecInotifyInitCheck.cpp.o
[ 68%] Building CXX object lib/StaticAnalyzer/Checkers/CMakeFiles/clangStaticAnalyzerCheckers.dir/UninitializedObjectChecker.cpp.o
building of '/nix/store/fg57qk8hzwkcgvnma0b9gi3pfcm19mp6-clang-7.0.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/izzp9cjr3fh1z0zgwp4fjnv3g4kjxh1c-zig-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/izzp9cjr3fh1z0zgwp4fjnv3g4kjxh1c-zig-0.3.0.drv' failed

@dtzWill dtzWill merged commit b5ba81a into NixOS:master Sep 30, 2018
@andrewrk
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewrk @xeji @GrahamcOfBorg @dtzWill