bazel-watcher: init at 0.5.0 #47448

kalbasit · 2018-09-27T23:58:21Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

/cc @mboes @Profpatsch @xeji

GrahamcOfBorg · 2018-09-28T00:13:24Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-28T00:21:55Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
warning: path '/nix/store/s7sl90airjh20c3bb7ips6gkh73nr6jh-bazel-watcher-2018-09-09-deps' claims to be content-addressed but isn't
error: unexpected end-of-file

srhb · 2018-09-28T07:12:03Z

pkgs/development/tools/bazel-watcher/default.nix

+      rm -rf $bazelOut/external/{local_*,\@local_*}
+    '';
+
+    sha256 = "0m7sjlbhg3p3l3mhs5smd28mj3zyzf6jrk3dgg0mjfb3zwfnfz32";


If you're sure this hash was correct at the time, this derivation is not stable. I immediately got a hash mismatch here.

interesting, thx for checking @srhb, probably something else needs to be removed before computing the hash.

@srhb can you try to build it and upload the $out for the /nix/store/...-bazel-watcher-2018-09-09-deps? Thank you!

pkgs/development/tools/bazel-watcher/default.nix

GrahamcOfBorg · 2018-09-28T17:24:08Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-28T17:30:24Z

Success on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09
shrinking /nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09/bin/ibazel
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09/bin
patching script interpreter paths in /nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09
checking for references to /build in /nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09...
cannot find section .dynamic
/nix/store/cp2p2x3h8n66y3v7rl9kjy32z6ijix6d-bazel-watcher-2018-09-09

GrahamcOfBorg · 2018-09-28T18:02:11Z

Success on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09
shrinking /nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09/bin/ibazel
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09/bin
patching script interpreter paths in /nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09
checking for references to /build in /nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09...
cannot find section .dynamic
/nix/store/vh94yivcacz3wjx3hcziyqfn2vv81gk5-bazel-watcher-2018-09-09

GrahamcOfBorg · 2018-09-28T18:02:32Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

srhb

Thanks, looks good and builds locally for me. :) A couple of things:

If this is not a released version, it should be named "bazel-watcher-unstable-2018-09-09". Is there any reason to not use a released version?

I believe the convention for the commit message is to also use the "version" as above, eg "init at 2018-09-09"

Bazel computes the default value of output_user_root before parsing the flag[0]. The computation of the default value involves getting the $USER from the environment. I don't have that variable when building with sandbox enabled. [0]: https://github.com/bazelbuild/bazel/blob/9323c57607d37f9c949b60e293b573584906da46/src/main/cpp/startup_options.cc#L123-L124

kalbasit · 2018-09-29T20:42:31Z

@srhb I was pointing to a specific revision because of my patch upstream bazelbuild/bazel-watcher@4d5928e that's needed for a successful packaging. But since my commit is just one after the released version v0.5.0, I have updated the PR to use the release and just import the patch.

PTAL.

GrahamcOfBorg · 2018-09-29T20:57:10Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-29T20:58:02Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
warning: path '/nix/store/csw5flq15rja43igbxqwmcvf5f0bxpbk-bazel-watcher-0.5.0-deps' claims to be content-addressed but isn't
error: unexpected end-of-file

srhb

LGTM, however I'd like to understand why it fails to build on ofborg. Are there any other assumptions about the -dep bit that break CI somehow?

kalbasit · 2018-09-30T16:08:37Z

@srhb not sure why but it seems to fail and succeed randomly. See #46864 for my attempt at understanding the failure.

kalbasit · 2018-10-01T14:38:25Z

@srhb sorry I gave you the wrong PR, I meant this #46509 (comment)

kalbasit · 2018-10-01T16:49:00Z

@GrahamcOfBorg build bazel-watcher

GrahamcOfBorg · 2018-10-01T16:49:13Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-01T16:50:03Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
warning: path '/nix/store/csw5flq15rja43igbxqwmcvf5f0bxpbk-bazel-watcher-0.5.0-deps' claims to be content-addressed but isn't
error: unexpected end-of-file

kalbasit · 2018-10-01T18:40:08Z

@GrahamcOfBorg build bazel-watcher

GrahamcOfBorg · 2018-10-01T18:40:21Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-01T18:41:11Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
warning: path '/nix/store/csw5flq15rja43igbxqwmcvf5f0bxpbk-bazel-watcher-0.5.0-deps' claims to be content-addressed but isn't
error: unexpected end-of-file

srhb · 2018-10-02T07:02:57Z

@grahamc Do you know what this error is about? It appears to work just fine locally, sandboxed and all. https://logs.nix.ci/?key=nixos/nixpkgs.47448&attempt_id=4a8c1c59-ccb8-424a-b8ed-ce5d6c8fe945

kalbasit · 2018-10-02T16:38:10Z

@grahamc also I tried restarting the build a few times in #46509, and it did end up succeeding a few time. I'll give it another try.

@GrahamcOfBorg build bazel-watcher

GrahamcOfBorg · 2018-10-02T16:38:22Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T16:44:18Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T16:44:27Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T16:46:03Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

warning: unable to download 'https://cache.nixos.org/dcagcm4bpzh3np0kaginayq7jdnbvli4.narinfo': HTTP error 503 (curl error: No error); retrying in 4622 ms
warning: unable to download 'https://cache.nixos.org/ypskrykzislxa3a4sx7pav1gkdv2jzhl.narinfo': HTTP error 503 (curl error: No error); retrying in 5139 ms
warning: unable to download 'https://cache.nixos.org/s0q9fdiyrv47invk6qkmiry2nf2pxn0b.narinfo': HTTP error 503 (curl error: No error); retrying in 18619 ms
warning: unable to download 'https://cache.nixos.org/dcagcm4bpzh3np0kaginayq7jdnbvli4.narinfo': HTTP error 503 (curl error: No error); retrying in 8548 ms
warning: unable to download 'https://cache.nixos.org/hfnqpkqjq80jyag478wcj1msqwzcgpdy.narinfo': HTTP error 503 (curl error: No error); retrying in 9070 ms
warning: unable to download 'https://cache.nixos.org/ypskrykzislxa3a4sx7pav1gkdv2jzhl.narinfo': HTTP error 503 (curl error: No error); retrying in 9215 ms
warning: unable to download 'https://cache.nixos.org/dcagcm4bpzh3np0kaginayq7jdnbvli4.narinfo': HTTP error 503 (curl error: No error); retrying in 17305 ms
warning: unable to download 'https://cache.nixos.org/hfnqpkqjq80jyag478wcj1msqwzcgpdy.narinfo': HTTP error 503 (curl error: No error); retrying in 19531 ms
warning: unable to download 'https://cache.nixos.org/ypskrykzislxa3a4sx7pav1gkdv2jzhl.narinfo': HTTP error 503 (curl error: No error); retrying in 17982 ms
error: unexpected end-of-file

GrahamcOfBorg · 2018-10-02T16:46:43Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
fixed-output derivation produced path '/nix/store/bp7540dm0hyy5cq8v2ffqidzy4kc4r4g-bazel-watcher-0.5.0-deps' with sha256 hash '1z25mgicbpiyc67xq8m93ysjrnh7f1nak4mwcxh5wf155imbxqxp' instead of the expected hash '1iyjvibvlwg980p7nizr6x5v31dyp4a344f0xn839x393583k59d'
cannot build derivation '/nix/store/ykcxdffb7s97lqqjrr7rl24ib2gbm2j9-bazel-watcher-0.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ykcxdffb7s97lqqjrr7rl24ib2gbm2j9-bazel-watcher-0.5.0.drv' failed

GrahamcOfBorg · 2018-10-02T16:57:57Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: bazel-watcher

Partial log (click to expand)

Building: no action
Building: no action
Building: no action
INFO: SHA256 (https://codeload.github.com/google/protobuf/zip/48cb18e5c419ddd23d9badcfe4e9df7bde1979b2) = b6b42f90c60b54732f764ae875623a9b05e6eede064173c36c6fea12dd376cdd
Building: no action
Building: no action
Building: no action
installing
warning: path '/nix/store/bp7540dm0hyy5cq8v2ffqidzy4kc4r4g-bazel-watcher-0.5.0-deps' claims to be content-addressed but isn't
error: unexpected end-of-file

srhb · 2018-10-03T22:03:31Z

The error was traced to a bug specific to nix 2.0.1. 2.0.2 or later are fine.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 28, 2018

srhb reviewed Sep 28, 2018

View reviewed changes

Profpatsch reviewed Sep 28, 2018

View reviewed changes

pkgs/development/tools/bazel-watcher/default.nix Show resolved Hide resolved

kalbasit force-pushed the nixpkgs_add-bazel-watcher branch 2 times, most recently from 5ccf839 to 27f0714 Compare September 28, 2018 17:46

srhb requested changes Sep 29, 2018

View reviewed changes

kalbasit added 3 commits September 29, 2018 13:28

build-bazel-package: remove any .git, .svn and .hg from external

90b7b4a

bazel-watcher: init at 0.5.0

86a5535

kalbasit force-pushed the nixpkgs_add-bazel-watcher branch from 27f0714 to 86a5535 Compare September 29, 2018 20:42

kalbasit changed the title ~~bazel-watcher: init at 4d5928e~~ bazel-watcher: init at 0.5.0 Sep 29, 2018

srhb approved these changes Sep 30, 2018

View reviewed changes

srhb merged commit 2e38f5f into NixOS:master Oct 3, 2018

kalbasit deleted the nixpkgs_add-bazel-watcher branch October 3, 2018 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bazel-watcher: init at 0.5.0 #47448

bazel-watcher: init at 0.5.0 #47448

kalbasit commented Sep 27, 2018 •

edited

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

srhb Sep 28, 2018

kalbasit Sep 28, 2018

kalbasit Sep 28, 2018 •

edited

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

srhb left a comment

kalbasit commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

srhb left a comment

kalbasit commented Sep 30, 2018 •

edited

kalbasit commented Oct 1, 2018 •

edited

kalbasit commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

kalbasit commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

srhb commented Oct 2, 2018

kalbasit commented Oct 2, 2018 •

edited

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

srhb commented Oct 3, 2018

bazel-watcher: init at 0.5.0 #47448

bazel-watcher: init at 0.5.0 #47448

Conversation

kalbasit commented Sep 27, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

srhb Sep 28, 2018

Choose a reason for hiding this comment

kalbasit Sep 28, 2018

Choose a reason for hiding this comment

kalbasit Sep 28, 2018 • edited

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

srhb left a comment

Choose a reason for hiding this comment

kalbasit commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

srhb left a comment

Choose a reason for hiding this comment

kalbasit commented Sep 30, 2018 • edited

kalbasit commented Oct 1, 2018 • edited

kalbasit commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

kalbasit commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

GrahamcOfBorg commented Oct 1, 2018

srhb commented Oct 2, 2018

kalbasit commented Oct 2, 2018 • edited

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

srhb commented Oct 3, 2018

kalbasit commented Sep 27, 2018 •

edited

kalbasit Sep 28, 2018 •

edited

kalbasit commented Sep 30, 2018 •

edited

kalbasit commented Oct 1, 2018 •

edited

kalbasit commented Oct 2, 2018 •

edited