Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.steam-udev: init at 1.0.0.51 #47447

Closed
wants to merge 2 commits into from
Closed

steamPackages.steam-udev: init at 1.0.0.51 #47447

wants to merge 2 commits into from

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 27, 2018 •
edited

Motivation for this change

Fixes #47314

I would like to have some input on the way I did this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre changed the title steamPackages.steam-udev: init at 1.0.0.56 steamPackages.steam-udev: init at 1.0.0.51 Sep 27, 2018
@nyanloutre
Copy link
Member Author

Next step would be to create a module to activate those rules easily

Mic92
Mic92 reviewed Sep 28, 2018
View reviewed changes
pkgs/games/steam/steam-udev.nix

installPhase = ''
install -d $out/lib/udev/rules.d
install -m644 lib/udev/rules.d/*.rules $out/lib/udev/rules.d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not exposing the rules in the original steamPackages.steam?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be added as udev rule package in a nixos module as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say it's a good way to do it I will do a new pull request

@nyanloutre nyanloutre mentioned this pull request Sep 28, 2018
Merged
9 tasks
@Mic92
Copy link
Member

Mic92 commented Sep 28, 2018

I prefer the other one.

@Mic92 Mic92 closed this Sep 28, 2018
@nyanloutre nyanloutre deleted the steam-udev branch October 2, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @Mic92 @GrahamcOfBorg