Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: remove useless patchelfUnstable build input #47461

Closed
wants to merge 1 commit into from
Closed

virtualbox: remove useless patchelfUnstable build input #47461

wants to merge 1 commit into from

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 28, 2018

Motivation for this change

It wasn't used at all because stdenv puts regular patchelf in PATH before it, see discussion in #45449

Things done
  • this should be a no-op rebuild

cc @dtzWill

@xeji
virtualbox: remove useless patchelfUnstable build input
c85aa05 
It wasn't used at all because stdenv puts regular patchelf in PATH
before it.
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtualbox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: virtualbox

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: virtualbox

Partial log (click to expand)

wrong ELF type
cannot find section .dynamic
strange: no string table
strange: no string table
shrinking RPATHs of ELF executables and libraries in /nix/store/m32y8129vqzm7gx32hbd4ama0rf3mi39-virtualbox-5.2.14-modsrc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/m32y8129vqzm7gx32hbd4ama0rf3mi39-virtualbox-5.2.14-modsrc
/nix/store/m32y8129vqzm7gx32hbd4ama0rf3mi39-virtualbox-5.2.14-modsrc/build_in_tmp: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/m32y8129vqzm7gx32hbd4ama0rf3mi39-virtualbox-5.2.14-modsrc...
postPatchMkspecs

@dtzWill
Copy link
Member

dtzWill commented Sep 28, 2018

Ha! Okay sure if my PR is needed to fix this then arguably it never did anything and since it seems to work regardless....

Even so I kinda would like to stop the production of errors like this (copied from Borg output above):

patchelf: patchelf.cc:1046: void ElfFile<Elf_Ehdr, Elf_Phdr, Elf_Shdr, Elf_Addr, Elf_Off, Elf_Dyn, Elf_Sym>::modifyRPath(ElfFile<Elf_Ehdr, Elf_Phdr, Elf_Shdr, Elf_Addr, Elf_Off, Elf_Dyn, Elf_Sym>::RPathOp, std::__cxx11::string) [with Elf_Ehdr = Elf32_Ehdr; Elf_Phdr = Elf32_Phdr; Elf_Shdr = Elf32_Shdr; Elf_Addr = unsigned int; Elf_Off = unsigned int; Elf_Dyn = Elf32_Dyn; Elf_Sym = Elf32_Sym; std::__cxx11::string = std::__cxx11::basic_string<char>]: Assertion `strTabAddr == rdi(shdrDynStr.sh_addr)' failed.

/nix/store/bqp3d4yhpx6h60fv8jww5id0nkm44034-patchelf-0.9/nix-support/setup-hook: line 7: 23193 Aborted

which is what that PR resolves, if a bit messily. Honestly I'm good with this if we don't like the approach/fix proposed there, but in absence of pushback prefer avoiding the errors and aborted processes.

@dtzWill
Copy link
Member

dtzWill commented Sep 28, 2018

But maybe that motivates just using patchelfUnstable by default instead. :)

@dtzWill
Copy link
Member

dtzWill commented Sep 28, 2018

For completeness and reference following ease, the PR I refer to above is this one: #47444

Sorry for not linking in the first place :).

@xeji
Copy link
Contributor Author

xeji commented Sep 28, 2018

Let's get rid of these weird errors. Closing in favor of #47444.

@xeji xeji closed this Sep 28, 2018
@xeji xeji deleted the p/virtualbox-patchelf branch February 17, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @dtzWill