Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.odoc: fix resolution of odoc.css #47458

Merged
merged 1 commit into from Sep 30, 2018
Merged

ocamlPackages.odoc: fix resolution of odoc.css #47458

merged 1 commit into from Sep 30, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 28, 2018

Motivation for this change

Fix call to odoc css -o …

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 28, 2018

@GrahamcOfBorg build ocamlPackages.odoc

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.odoc

Partial log (click to expand)

As a result, the rule is currently ignored, however this will become an error in the future.
To keep the current behavior and get rid of this warning, add a field (fallback) to the rule.
installing
Processing file odoc.install as odoc.
post-installation fixup
moving /nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0/doc to /nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0/share/doc
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0/lib  /nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0/bin
patching script interpreter paths in /nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0
/nix/store/vmjsi19d5a6bddr1fb69yw3r5g1g9pyk-ocaml4.06.1-odoc-1.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.odoc

Partial log (click to expand)

post-installation fixup
moving /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/doc to /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0
shrinking /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/bin/odoc
shrinking /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/lib/ocaml/4.06.1/site-lib/odoc/odoc.cmxs
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/lib  /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0/bin
patching script interpreter paths in /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0
checking for references to /build in /nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0...
/nix/store/w833rwczf7fd5903qvz5i571n6jklqc8-ocaml4.06.1-odoc-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.odoc

Partial log (click to expand)

post-installation fixup
moving /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/doc to /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0
shrinking /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/lib/ocaml/4.06.1/site-lib/odoc/odoc.cmxs
shrinking /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/bin/odoc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/lib  /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0/bin
patching script interpreter paths in /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0
checking for references to /build in /nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0...
/nix/store/50qsgdvj60yabjzd25gp1x7zh80gnx57-ocaml4.06.1-odoc-1.2.0

@vbgl vbgl merged commit b46666a into NixOS:master Sep 30, 2018
@vbgl vbgl deleted the ocaml-odoc-fix-css branch September 30, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @GrahamcOfBorg