gmic_krita_qt: Init at 2.3.6 #47442

nek0 · 2018-09-27T22:46:03Z

Motivation for this change

This tool has been missing in the toolbox.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Mic92 · 2018-09-28T07:12:05Z

pkgs/tools/graphics/gmic-qt/default.nix

+  gmic_qt = fetchFromGitHub {
+    owner = "c-koi";
+    repo = "gmic-qt";
+    rev = "9e992cff2db418032b849458f5c9443267c7162c";


Do they have release versions or git tags instead of hashes?
Do you also have a hint for future people to know what git hashes they have to use that are compatible with each other?

yes, they use tags with version numbers. Since the tools have the same version numbers and are relaesed almost synchronously, there should be no problem.

Ok then please use tags to fetch the source.

Mic92 · 2018-09-28T07:13:10Z

pkgs/tools/graphics/gmic-qt/default.nix

+
+    cp ${gmic_stdlib} gmic/src/gmic_stdlib.h
+
+    make -C gmic/src CImg.h gmic_stdlib.h


It looks a bit cleaner if this would be in preConfigure.

Mic92 · 2018-09-28T11:46:32Z

pkgs/tools/graphics/gmic-qt/default.nix

    cp ${gmic_stdlib} gmic/src/gmic_stdlib.h

    make -C gmic/src CImg.h gmic_stdlib.h
-    cd gmic_qt


This should stay after build or else you have to do: make -C ../gmic/src CImg.h gmic_stdlib.h, which is also possible.

Mic92 · 2018-09-28T11:46:54Z

pkgs/tools/graphics/gmic-qt/default.nix

+    cd gmic_qt
+  '';
+
+  preConfigure = ''
    cp ${gmic_stdlib} gmic/src/gmic_stdlib.h


This can stay in unpackPhase.

Mic92 · 2018-09-28T12:23:10Z

@GrahamcOfBorg build gmic_krita_qt

Mic92 · 2018-09-28T12:23:36Z

pkgs/top-level/all-packages.nix

@@ -1370,6 +1370,8 @@ with pkgs;

  gmic = callPackage ../tools/graphics/gmic { };

+  gmic-qt = callPackage ../tools/graphics/gmic-qt { };


gmic_krita_qt or gmic_qt?

yeah. gmic_krita_qt is more accurate

GrahamcOfBorg · 2018-09-28T12:23:42Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic_krita_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_krita_qt' because:
error: attribute 'gmic_krita_qt' in selection path 'gmic_krita_qt' not found

GrahamcOfBorg · 2018-09-28T12:24:01Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: gmic_krita_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_krita_qt' because:
error: attribute 'gmic_krita_qt' in selection path 'gmic_krita_qt' not found

GrahamcOfBorg · 2018-09-28T12:25:16Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gmic_krita_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_krita_qt' because:
error: attribute 'gmic_krita_qt' in selection path 'gmic_krita_qt' not found

Mic92 · 2018-09-28T12:28:18Z

@GrahamcOfBorg build gmic_qt

GrahamcOfBorg · 2018-09-28T12:28:31Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_qt' because:
error: attribute 'gmic_qt' in selection path 'gmic_qt' not found

GrahamcOfBorg · 2018-09-28T12:29:01Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: gmic_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_qt' because:
error: attribute 'gmic_qt' in selection path 'gmic_qt' not found

GrahamcOfBorg · 2018-09-28T12:30:29Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gmic_qt

Partial log (click to expand)

Cannot nix-instantiate `gmic_qt' because:
error: attribute 'gmic_qt' in selection path 'gmic_qt' not found

Mic92 · 2018-09-28T12:32:12Z

@GrahamcOfBorg build gmic-qt

GrahamcOfBorg · 2018-09-28T12:32:22Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic-qt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-28T12:34:52Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: gmic-qt

Partial log (click to expand)

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122    0   122    0     0    326      0 --:--:-- --:--:-- --:--:--   326
100 37.2M    0 37.2M    0     0  12.5M      0 --:--:--  0:00:02 --:--:-- 16.6M
unpacking source archive /build/v.2.3.6.tar.gz
fixed-output derivation produced path '/nix/store/fzlsair6andvfw8dlydn6yjv33sb8ps9-source' with sha256 hash '1yg9ri3n07drv8gz4x0mn39ryi801ibl26jaza47m19ma893m8fi' instead of the expected hash '0f69r460lyfb021m7bs8s4rxa3png51cbp1izywsy3sprjd1s57p'
copying path '/nix/store/rixcz5yr1km9li6glb1d4n50jfpihfdj-kio-5.50.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/3sa1z6znh5q74j0n9gfm7lbz6b59dfh7-krita-4.1.1' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/fwl6wsdjhpj9ydk643p71x13mldf84fw-gmic-qt-2.3.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/fwl6wsdjhpj9ydk643p71x13mldf84fw-gmic-qt-2.3.6.drv' failed

GrahamcOfBorg · 2018-09-28T12:34:55Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: gmic-qt

Partial log (click to expand)

copying path '/nix/store/4rq4db7pawrvlnarsf7m6h27mysf7rm3-kxmlgui-5.50.0' from 'https://cache.nixos.org'...
copying path '/nix/store/npmirnf2j67aqfa056ng8q963fcy1bb3-ktextwidgets-5.50.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/vpc7c9rh6g7d80nhpaqd25s28gghhalc-kwallet-5.50.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/fzv6d014xdj8yn7sf29h9yihizi2c9yh-kxmlgui-5.50.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/5r7y5ic7z7s6z05q9fhpr5dmvh8wy66y-kbookmarks-5.50.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ldchfa852jzi5wckfmif0z1i11lpdixy-kio-5.50.0' from 'https://cache.nixos.org'...
copying path '/nix/store/yz2wmsni941q4r726dr40x9qz0r4hlr0-kio-5.50.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/ni6p6rx7qdkwh6j6bkgq91vfds04gj07-krita-4.1.1' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/x9w1rz3nmnbga9kr8aw7xq714l90gc4v-gmic-qt-2.3.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/x9w1rz3nmnbga9kr8aw7xq714l90gc4v-gmic-qt-2.3.6.drv' failed

symphorien · 2018-09-28T12:45:13Z

pkgs/tools/graphics/gmic-qt/default.nix

@@ -0,0 +1,82 @@
+{ stdenv, fetchurl, fetchFromGitHub, cmake, ninja, pkgconfig, qt5


according to https://nixos.org/nixpkgs/manual/#sec-language-qt you should not use qt5 as an argument but use libsForQt5.callPackage (or maybe a plugin qualifies as a library ?)

well, gmic_krita_qt depends on qt5 as its gui framework...

True, but if you use libsForQt5.callPackage in all-packages.nix then you can reference dependencies directly instead of using the qt5 set. For example { qtbase } instead of { qt5 }.

This ensures that all dependencies have the same qt5 version.

i changed it in the latest commit

Mic92 · 2018-09-28T14:09:18Z

This also need to be fixed:

fixed-output derivation produced path '/nix/store/fzlsair6andvfw8dlydn6yjv33sb8ps9-source' with sha256 hash '1yg9ri3n07drv8gz4x0mn39ryi801ibl26jaza47m19ma893m8fi' instead of the expected hash '0f69r460lyfb021m7bs8s4rxa3png51cbp1izywsy3sprjd1s57p'

Mic92 · 2018-09-28T14:09:29Z

see ofborg output.

Mic92 · 2018-09-28T14:18:18Z

@GrahamcOfBorg build gmic-qt

GrahamcOfBorg · 2018-09-28T14:18:48Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic-qt

Partial log (click to expand)

Cannot nix-instantiate `gmic-qt' because:
error: attribute 'gmic-qt' in selection path 'gmic-qt' not found

GrahamcOfBorg · 2018-09-28T14:19:04Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: gmic-qt

Partial log (click to expand)

Cannot nix-instantiate `gmic-qt' because:
error: attribute 'gmic-qt' in selection path 'gmic-qt' not found

Mic92 · 2018-09-28T14:20:01Z

@GrahamcOfBorg build gmic_krita_qt

GrahamcOfBorg · 2018-09-28T14:20:20Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic_krita_qt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-28T14:20:31Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gmic-qt

Partial log (click to expand)

Cannot nix-instantiate `gmic-qt' because:
error: attribute 'gmic-qt' in selection path 'gmic-qt' not found

GrahamcOfBorg · 2018-09-28T14:20:48Z

Failure on x86_64-linux (full log)

Attempted: gmic_krita_qt

Partial log (click to expand)

CMake Error at CMakeLists.txt:83 (message):


  Version numbers of files 'gmic.h' (236) and 'CImg.h' (240) mismatch


-- Configuring incomplete, errors occurred!
See also "/build/gmic_qt/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/cnn327ijkasq6gidngbic7iiy24gjdfl-gmic_krita_qt-2.3.6.drv' failed with exit code 1
error: build of '/nix/store/cnn327ijkasq6gidngbic7iiy24gjdfl-gmic_krita_qt-2.3.6.drv' failed

GrahamcOfBorg · 2018-09-28T14:22:36Z

Failure on aarch64-linux (full log)

Attempted: gmic_krita_qt

Partial log (click to expand)

CMake Error at CMakeLists.txt:83 (message):


  Version numbers of files 'gmic.h' (236) and 'CImg.h' (240) mismatch


-- Configuring incomplete, errors occurred!
See also "/build/gmic_qt/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/39v9nmcxs7s9ci143gqhylsrggq0jdrr-gmic_krita_qt-2.3.6.drv' failed with exit code 1
error: build of '/nix/store/39v9nmcxs7s9ci143gqhylsrggq0jdrr-gmic_krita_qt-2.3.6.drv' failed

Mic92 · 2018-09-28T14:22:57Z

@GrahamcOfBorg build gmic_krita_qt

GrahamcOfBorg · 2018-09-28T14:23:28Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gmic_krita_qt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-28T14:32:57Z

Success on aarch64-linux (full log)

Attempted: gmic_krita_qt

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6
shrinking /nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6/bin/gmic_krita_qt
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6/bin
patching script interpreter paths in /nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6
checking for references to /build in /nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6...
postPatchMkspecs
postPatchMkspecs
/nix/store/2i1f7ccfwbsqyqpac8naxnwqbmfjmrzp-gmic_krita_qt-2.3.6

GrahamcOfBorg · 2018-09-28T14:46:53Z

Success on x86_64-linux (full log)

Attempted: gmic_krita_qt

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6
shrinking /nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6/bin/gmic_krita_qt
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6/bin
patching script interpreter paths in /nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6
checking for references to /build in /nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6...
postPatchMkspecs
postPatchMkspecs
/nix/store/szjxhjs1ripqb41bjrza95hkfpqyp29f-gmic_krita_qt-2.3.6

nek0 added 5 commits September 27, 2018 19:28

add gmic-qt

49bee19

still trying

c26f3ba

thank you @Mic92

b199549

fixing and cleaning

04d5ff8

final cleaning

24775df

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 27, 2018

Mic92 reviewed Sep 28, 2018

View reviewed changes

moving stuff around

059286d

Mic92 reviewed Sep 28, 2018

View reviewed changes

nek0 added 4 commits September 28, 2018 13:53

sokoban

ac4cfba

use tags

6d77f41

fix wrong location

92211c0

add clarification

491a401

Mic92 reviewed Sep 28, 2018

View reviewed changes

symphorien reviewed Sep 28, 2018

View reviewed changes

renaming and restructuring

b7f2c92

fix hash

6ba1ef4

fix CImg dependency

4303814

Mic92 merged commit a193572 into NixOS:master Sep 29, 2018


		cp ${gmic_stdlib} gmic/src/gmic_stdlib.h

		make -C gmic/src CImg.h gmic_stdlib.h

		@@ -1370,6 +1370,8 @@ with pkgs;

		gmic = callPackage ../tools/graphics/gmic { };

		gmic-qt = callPackage ../tools/graphics/gmic-qt { };

		@@ -0,0 +1,82 @@
		{ stdenv, fetchurl, fetchFromGitHub, cmake, ninja, pkgconfig, qt5

gmic_krita_qt: Init at 2.3.6 #47442

gmic_krita_qt: Init at 2.3.6 #47442

Conversation

nek0 commented Sep 27, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 commented Sep 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Mic92 commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Mic92 commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Sep 28, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 commented Sep 28, 2018

Mic92 commented Sep 28, 2018

Mic92 commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Mic92 commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Mic92 commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

GrahamcOfBorg commented Sep 28, 2018

Mic92 Sep 28, 2018 •

edited