Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: don't restart user-runtime-dir@ on upgrades #47462

Merged
merged 1 commit into from Sep 28, 2018
Merged

systemd: don't restart user-runtime-dir@ on upgrades #47462

merged 1 commit into from Sep 28, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 28, 2018 •
edited

Likewise logind we should not try to restart this service after upgrade,
the user's current session depends on it.
This should be backported to stable.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
systemd: don't restart user-runtime-dir@ on upgrades
aa69bb5 
Likewise logind we should not try to restart this service after upgrade,
the user's current session depends on it.
@Mic92 Mic92 added this to the 18.09 milestone Sep 28, 2018
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 28, 2018
@Mic92 Mic92 requested a review from xeji September 28, 2018 10:40
@Mic92
Copy link
Member Author

Mic92 commented Sep 28, 2018

This was introduced in systemd v239

@srhb
Copy link
Contributor

srhb commented Sep 28, 2018 •
edited

I think this will fix #47387

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

/nix/store/755srn9lwkidg9k9w6mvwd7806r8wbfz-systemd-239

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

copying path '/nix/store/n6af8xvwb1smfvf1r3378mcvv68v4fwk-libnfnetlink-1.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/89416lzmg1jag9y78xybhjgfhnlqkka7-libnetfilter_conntrack-1.0.7' from 'https://cache.nixos.org'...
copying path '/nix/store/3vgw22dmhpzayw6dz5h0dw2g0qzsxggd-libnftnl-1.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/v37yclc493mhcnlljr6y1naxhafnan10-linux-pam-1.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/kngxn7wxz2jcmblnxdsgqr6hmyvn6mzd-iptables-1.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/69xbfqsasys5p1ysmgz5kc44n252lbrl-kbd-2.0.4' from 'https://cache.nixos.org'...
copying path '/nix/store/rbqi7x011x44wl1vs502q0jln01d1qlb-shadow-4.6' from 'https://cache.nixos.org'...
copying path '/nix/store/r9iv5fn17xlhx5xr0v9yyaqwvs9yq5fd-util-linux-2.32.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/kcdgk5ww9h7amv7vk4bmsl2qlhv33z2r-systemd-239' from 'https://cache.nixos.org'...
/nix/store/kcdgk5ww9h7amv7vk4bmsl2qlhv33z2r-systemd-239

@Mic92 Mic92 mentioned this pull request Sep 28, 2018
Closed
@Mic92
Copy link
Member Author

Mic92 commented Sep 28, 2018

@srhb yes.

@Mic92 Mic92 merged commit 1d65e47 into NixOS:master Sep 28, 2018
@Mic92 Mic92 deleted the fix-logind-user-temp branch September 28, 2018 11:10
@Mic92
Copy link
Member Author

Mic92 commented Sep 28, 2018

backport: 1e9f50f

@dtzWill
Copy link
Member

dtzWill commented Sep 28, 2018

Yay!! Thanks!

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
1.severity: blocker 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @srhb @GrahamcOfBorg @dtzWill @samueldr