Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.term-rewriting: doJailbreak and dontCheck #47456

Merged
merged 1 commit into from Sep 28, 2018
Merged

haskellPackages.term-rewriting: doJailbreak and dontCheck #47456

merged 1 commit into from Sep 28, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Sep 28, 2018 •
edited

Motivation for this change

fixes #47439

Upstream issue: haskell-rewriting/term-rewriting#11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member

Thanks Sarah, I'll merge once ofborg says it builds.

@GrahamcOfBorg build haskellPackages.term-rewriting

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.term-rewriting

Partial log (click to expand)

dist/doc/html/term-rewriting/term-rewriting.txt
installing
Installing library in /nix/store/8sp4rjpp5khq6rsgj9k6xmc15ssbz9r5-term-rewriting-0.2.1.1/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/term-rewriting-0.2.1.1-JZk6DYncF9W8iJLTjQ2Sab
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8sp4rjpp5khq6rsgj9k6xmc15ssbz9r5-term-rewriting-0.2.1.1/lib
patching script interpreter paths in /nix/store/8sp4rjpp5khq6rsgj9k6xmc15ssbz9r5-term-rewriting-0.2.1.1
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/sy8qgiapgayx4fcrsgx15kl52g9rgqk2-term-rewriting-0.2.1.1-doc
/nix/store/8sp4rjpp5khq6rsgj9k6xmc15ssbz9r5-term-rewriting-0.2.1.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.term-rewriting

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.term-rewriting

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n13zcwahzvpw4vdinbihlwd3haf08d3q-term-rewriting-0.2.1.1/lib
patching script interpreter paths in /nix/store/n13zcwahzvpw4vdinbihlwd3haf08d3q-term-rewriting-0.2.1.1
checking for references to /build in /nix/store/n13zcwahzvpw4vdinbihlwd3haf08d3q-term-rewriting-0.2.1.1...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/glrn21q59ibwfa10azn9r2n1a399syr5-term-rewriting-0.2.1.1-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/glrn21q59ibwfa10azn9r2n1a399syr5-term-rewriting-0.2.1.1-doc
checking for references to /build in /nix/store/glrn21q59ibwfa10azn9r2n1a399syr5-term-rewriting-0.2.1.1-doc...
/nix/store/n13zcwahzvpw4vdinbihlwd3haf08d3q-term-rewriting-0.2.1.1

@basvandijk basvandijk merged commit 5af67a3 into NixOS:master Sep 28, 2018
@srhb srhb deleted the haskellPackages-term-rewriting branch September 28, 2018 08:45
srhb added a commit that referenced this pull request Sep 28, 2018
@srhb
haskellPackages.term-rewriting: doJailbreak and dontCheck
0e0cd2f 
(cherry picked from commit 5c45ca0)
Backport of #47456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

haskellPackages.term-rewriting build failure
3 participants
@srhb @basvandijk @GrahamcOfBorg