Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update section about imperative containers #47473

Merged
merged 1 commit into from Sep 29, 2018
Merged

doc: Update section about imperative containers #47473

merged 1 commit into from Sep 29, 2018

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Sep 28, 2018

Nix commands inside the container have been broken since 18.03,
and no fix is yet in sight. Lets remove from the documentation
that this is a usecase that we support, as it doesn't seem
likely that this will be fixed before 18.09 either.

See #40355

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@arianvp
doc: Update section about imperative containers
f309440 
Nix commands inside the container have been broken since 18.03,
and no fix is yet in sight.  Lets remove from the documentation
that this is a usecase that we support, as it doesn't seem
likely that this will be fixed before 18.09 either.

See NixOS#40355
@arianvp
Copy link
Member Author

arianvp commented Sep 28, 2018

cc @vcunat @samueldr Perhaps we want to backport this to release-18.09

@Mic92 Mic92 merged commit d6665b4 into NixOS:master Sep 29, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 29, 2018

backport: b72abcf

@dezgeg
Copy link
Contributor

dezgeg commented Sep 30, 2018

This breaks the manual build, please re-spin: https://nix-cache.s3.amazonaws.com/log/wnjcy6n5f871bpyy9nd06smiz1ggv99c-nixos-manual-combined.drv

@samueldr
Copy link
Member

@grahamc fixed it meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arianvp @Mic92 @dezgeg @samueldr @GrahamcOfBorg