Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3768913cc9ec
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e9f50f1569a
Choose a head ref
  • 5 commits
  • 9 files changed
  • 5 contributors

Commits on Sep 28, 2018

  1. haskellPackages.term-rewriting: doJailbreak and dontCheck

    (cherry picked from commit 5c45ca0)
    Backport of #47456
    srhb committed Sep 28, 2018
    Copy the full SHA
    0e0cd2f View commit details
  2. Add ssh backdoor to VM tests infrastructure.

    Thanks to @dezgeg for prototype implementation, I've
    cleaned it up and added documentation.
    
    (cherry picked from commit d6e3db4)
    Signed-off-by: Domen Kožar <domen@dev.si>
    dezgeg authored and domenkozar committed Sep 28, 2018
    Copy the full SHA
    a7fa8e1 View commit details
  3. linuxPackages.jool: 3.5.7 -> unstable-20180706 (#47284)

    3.5.7 doesn't build with kernel 4.14.71.
    Needs most recent upstream revision to build, which supports
    kernels up to 4.17.
    
    (cherry picked from commit f0e4b31)
    xeji committed Sep 28, 2018
    Copy the full SHA
    0c29a51 View commit details
  4. retroshare: mark as broken (#47350)

    Broken by libupnp: 1.6.21 -> 1.8.3 (#41684).
    
    (cherry picked from commit eeac44c)
    orivej authored and xeji committed Sep 28, 2018
    Copy the full SHA
    1e1821c View commit details
  5. systemd: don't restart user-runtime-dir@ on upgrades

    Likewise logind we should not try to restart this service after upgrade,
    the user's current session depends on it.
    
    (cherry picked from commit aa69bb5)
    Mic92 committed Sep 28, 2018
    Copy the full SHA
    1e9f50f View commit details
36 changes: 36 additions & 0 deletions nixos/doc/manual/development/debugging-nixos-tests.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<section xmlns="http://docbook.org/ns/docbook"
xmlns:xlink="http://www.w3.org/1999/xlink"
xmlns:xi="http://www.w3.org/2001/XInclude"
version="5.0"
xml:id="sec-debugging-nixos-tests">
<title>Debugging NixOS tests</title>

<para>
Tests may fail and infrastructure offers access to inspect machine state.
</para>

<para>
To prevent test from stopping and cleaning up, insert a sleep command:
</para>

<programlisting>
$machine->succeed("sleep 84000");
</programlisting>

<para>
As soon as machine starts run as root:
</para>

<programlisting>
nix-shell -p socat --run "socat STDIO,raw,echo=0,escape=0x11 UNIX:/tmp/nix-build-vm-test-run-*.drv-0/vm-state-machine/backdoor"
</programlisting>

<para>
You may need to find the correct path, replacing <literal>/tmp</literal>, <literal>*</literal> or <literal>machine</literal>.
</para>

<para>
Press "enter" to open up console and login as "root". After you're done, press "ctrl-q" to exit the console.
</para>

</section>
1 change: 1 addition & 0 deletions nixos/doc/manual/development/nixos-tests.xml
Original file line number Diff line number Diff line change
@@ -16,4 +16,5 @@ xlink:href="https://github.com/NixOS/nixpkgs/tree/master/nixos/tests">nixos/test
<xi:include href="writing-nixos-tests.xml" />
<xi:include href="running-nixos-tests.xml" />
<xi:include href="running-nixos-tests-interactively.xml" />
<xi:include href="debugging-nixos-tests.xml" />
</chapter>
6 changes: 4 additions & 2 deletions nixos/lib/test-driver/Machine.pm
Original file line number Diff line number Diff line change
@@ -155,8 +155,10 @@ sub start {
$ENV{USE_TMPDIR} = 1;
$ENV{QEMU_OPTS} =
($self->{allowReboot} ? "" : "-no-reboot ") .
"-monitor unix:./monitor -chardev socket,id=shell,path=./shell " .
"-device virtio-serial -device virtconsole,chardev=shell " .
"-monitor unix:./monitor " .
"-chardev socket,id=shell,path=./shell -device virtio-serial -device virtconsole,chardev=shell " .
# socket backdoor, see "Debugging NixOS tests" section in NixOS manual
"-chardev socket,id=backdoor,path=./backdoor,server,nowait -device virtio-serial -device virtconsole,chardev=backdoor " .
"-device virtio-rng-pci " .
($showGraphics ? "-serial stdio" : "-nographic") . " " . ($ENV{QEMU_OPTS} || "");
chdir $self->{stateDir} or die;
3 changes: 3 additions & 0 deletions nixos/modules/system/boot/systemd.nix
Original file line number Diff line number Diff line change
@@ -886,6 +886,9 @@ in
#systemd.services.systemd-logind.restartTriggers = [ config.environment.etc."systemd/logind.conf".source ];
systemd.services.systemd-logind.restartIfChanged = false;
systemd.services.systemd-logind.stopIfChanged = false;
# The user-runtime-dir@ service is managed by systemd-logind we should not touch it or else we break the users' sessions.
systemd.services."user-runtime-dir@".stopIfChanged = false;
systemd.services."user-runtime-dir@".restartIfChanged = false;
systemd.services.systemd-journald.restartTriggers = [ config.environment.etc."systemd/journald.conf".source ];
systemd.services.systemd-journald.stopIfChanged = false;
systemd.targets.local-fs.unitConfig.X-StopOnReconfiguration = true;
3 changes: 2 additions & 1 deletion nixos/modules/testing/test-instrumentation.nix
Original file line number Diff line number Diff line change
@@ -55,7 +55,8 @@ with import ../../lib/qemu-flags.nix { inherit pkgs; };
systemd.services."serial-getty@hvc0".enable = false;

# Only use a serial console, no TTY.
virtualisation.qemu.consoles = [ qemuSerialDevice ];
# hvc1: socket backdoor, see "Debugging NixOS tests" section in NixOS manual
virtualisation.qemu.consoles = [ "hvc1" qemuSerialDevice ];

boot.initrd.preDeviceCommands =
''
1 change: 1 addition & 0 deletions pkgs/applications/networking/p2p/retroshare/default.nix
Original file line number Diff line number Diff line change
@@ -54,5 +54,6 @@ stdenv.mkDerivation rec {
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = [ maintainers.domenkozar ];
broken = true; # broken by libupnp: 1.6.21 -> 1.8.3 (#41684)
};
}
3 changes: 3 additions & 0 deletions pkgs/development/haskell-modules/configuration-common.nix
Original file line number Diff line number Diff line change
@@ -1001,6 +1001,9 @@ self: super: {
'';
});

# https://github.com/haskell-rewriting/term-rewriting/issues/11
term-rewriting = dontCheck (doJailbreak super.term-rewriting);

# https://github.com/nick8325/twee/pull/1
twee-lib = dontHaddock super.twee-lib;

2 changes: 1 addition & 1 deletion pkgs/os-specific/linux/jool/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchFromGitHub, kernel }:

assert stdenv.lib.versionOlder kernel.version "4.17";
assert stdenv.lib.versionOlder kernel.version "4.18";

let
sourceAttrs = (import ./source.nix) { inherit fetchFromGitHub; };
6 changes: 3 additions & 3 deletions pkgs/os-specific/linux/jool/source.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{ fetchFromGitHub }:

rec {
version = "3.5.7";
version = "unstable-20180706";
src = fetchFromGitHub {
owner = "NICMx";
repo = "Jool";
rev = "v${version}";
sha256 = "1qxhrchhm4lbyxkp6wm47a85aa4d9wlyy3kdijl8rarngvh8j1yx";
rev = "de791931d94e972c36bb3c102a9cadab5230c285";
sha256 = "09mr7lc9k17znpslsfmndx4vgl240llcgblxm92fizmwz23y1d6c";
};
}