Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.steam: 1.0.0.51 -> 1.0.0.56 #47476

Closed
wants to merge 1 commit into from
Closed

steamPackages.steam: 1.0.0.51 -> 1.0.0.56 #47476

wants to merge 1 commit into from

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 28, 2018 •
edited

Motivation for this change

This update include udev rules needed for HTC vive and more supported controller
The udev rules are included in the package by this PR #47455

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 28, 2018

Can you put both changes in the same pull request?

@nyanloutre
Copy link
Member Author

@Mic92 OK it's in this one : #47455

@nyanloutre nyanloutre closed this Sep 29, 2018
@nyanloutre nyanloutre deleted the steamPackages.steam-1-0-0-56 branch October 2, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @Mic92 @GrahamcOfBorg