Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxvt_unicode: fixes annoying locale mismatch bug #47457

Closed
wants to merge 1 commit into from

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented Sep 28, 2018

Motivation for this change

We've been here before: if the package is build with a different glibclocale version than the default on the system it is run on, it results in bad behaviour. (Especially annoying for non-nixos systems).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

I don't think we should make this change. Adding glibcLocales increases closure size for rxvt_unicode-with-plugins from 122M to 249M. This will need to be fixed in a more general (and lightweight) way, not by adding glibcLocales to every package. See ongoing discussion in #38991.

@bfortz
Copy link
Contributor Author

bfortz commented Sep 28, 2018

@xeji Thanks, I learned a lot today 😄 and I agree. My solution was way too agressive for my problem. On nixos, in fact the problem does not appear because LOCALE_ARCHIVE is exported correctly. But on other distributions, the variable is not set. Asking users to do it manually is not the best way to proceed, so it should be set by default. Would it make sense to add it to .nix-profile/etc/profile.d/nix.sh or is there a better place?

Update: My suggestion above is not good, it might interfere with applications on the host system in a bad way. Also, the glicLocales problem in this case is linked to perl, not to urxvt directiy I think.

@bfortz bfortz closed this Sep 28, 2018
@bfortz bfortz deleted the urxvt branch September 28, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants