nixos/zsh: use `escapeShellArg' for shell aliases #47471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously single quotes were used by default for aliases and the module never warned about possible collisions when having a shell alias which relies on single quotes. Adding `escapeShellArg` works around this fixes the issue and ensures that a properly quoted value is written to `/etc/zshrc`.
Ma27
force-pushed
the
fix-zsh-aliasing
branch
from
9508668
to
10e5c14
Compare
Ma27
changed the title
|
Has this also been done for Bash? |
8573
added a commit
to 8573/nixpkgs
that referenced
this pull request
Oct 6, 2018
This patch uses the library function `lib.escapeShellArg` to improve the handling of shell aliases in the NixOS module `bash`, copying the corresponding change made to the `zsh` module in commit 1e211a7 (for which GitHub pull request NixOS#47471 was filed). This patch resolves GitHub issue NixOS#16973. This change presumably also should be copied to the `fish` module, but I don't know `fish` syntax so that won't be done by me. GitHub: Close NixOS#16973.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously single quotes were used by default for aliases and the module
never warned about possible collisions when having a shell alias which
relies on single quotes.
Adding
escapeShellArgworks around fixes the this issue and ensures that aproperly quoted value is written to
/etc/zshrc.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)