Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.steam: add udev rules and update to 1.0.0.56 #47455

Merged
merged 4 commits into from Oct 1, 2018
Merged

steamPackages.steam: add udev rules and update to 1.0.0.56 #47455

merged 4 commits into from Oct 1, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 28, 2018 •
edited

Motivation for this change

Fixes #47314
Close #47447

Hello @Mic92 I did your suggestion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from jagajaga September 28, 2018 11:54
@Mic92
Copy link
Member

Mic92 commented Sep 28, 2018

cc @abbradar

@nyanloutre nyanloutre mentioned this pull request Sep 28, 2018
Closed
9 tasks
@nyanloutre nyanloutre changed the title steamPackages.steam: add udev rules steamPackages.steam: add udev rules and update to 1.0.0.56 Sep 29, 2018
@nyanloutre
Copy link
Member Author

I also added a module to use the udev rules so everything is packed in this PR

@Mic92 Mic92 merged commit bc0d87a into NixOS:master Oct 1, 2018
@nyanloutre nyanloutre deleted the steamPackages.steam-udev branch October 2, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: steam 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @Mic92 @GrahamcOfBorg