Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare to None using identity is operator #49486

Merged
merged 1 commit into from Oct 30, 2018
Merged

Compare to None using identity is operator #49486

merged 1 commit into from Oct 30, 2018

Conversation

janisozaur
Copy link
Contributor

This is a trivial change that replaces == operator with is operator, following PEP 8 guideline:

Comparisons to singletons like None should always be done with is or is not, never the equality operators.

https://legacy.python.org/dev/peps/pep-0008/#programming-recommendations

@janisozaur
Compare to None using identity is operator
4af8672 
This is a trivial change that replaces `==` operator with `is` operator, following PEP 8 guideline:

> Comparisons to singletons like None should always be done with is or is not, never the equality operators.

https://legacy.python.org/dev/peps/pep-0008/#programming-recommendations
@FRidh FRidh merged commit 3f05186 into NixOS:master Oct 30, 2018
@janisozaur
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janisozaur @FRidh @GrahamcOfBorg