Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] buildRustPackage: fix regex for separating lib and bin #49474

Closed
wants to merge 1 commit into from
Closed

[18.09] buildRustPackage: fix regex for separating lib and bin #49474

wants to merge 1 commit into from

Conversation

andir
Copy link
Member

@andir andir commented Oct 30, 2018

This is the backport of #48020 (cc @erictapen).

I just started running some builds with these changes to see if it actually breaks/fixes things.

Motivation for this change
E.g. exa was wrongly put into /lib, as it matches

  .*.a

but not

  .*\.a
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@erictapen @andir
buildRustPackage: fix regex for separating lib and bin
3f61425 
E.g. exa was wrongly put into /lib, as it matches

  .*.a

but not

  .*\.a

(cherry picked from commit 64d0676)
@erictapen
Copy link
Member

I think this was already backported in 5647e9a, see also #48020 (comment).

@andir
Copy link
Member Author

andir commented Oct 31, 2018

ahh right, it now is within the staging game.. I should have checked more precisely.

@andir andir closed this Oct 31, 2018
@andir andir deleted the 18.09/build-rust-package-exa branch October 31, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @erictapen @GrahamcOfBorg