Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbpst: init at unstable-2018-01-11 #49459

Merged
merged 1 commit into from Oct 30, 2018
Merged

pbpst: init at unstable-2018-01-11 #49459

merged 1 commit into from Oct 30, 2018

Conversation

tmplt
Copy link
Member

@tmplt tmplt commented Oct 30, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I'm only unsure of two things:

  • should a package from latest master HEAD be versioned with a "-git" suffix instead of a short hash?
  • the code I sed out is a for i in curl jansson; do check_file /usr/lib/lib$i; done; should it be handled some other way?

@Synthetica9
Copy link
Member

should a package from latest master HEAD be versioned with a "-git" suffix instead of a short hash?

I'd say you should use the date of the last commit. However, only 11 commits have been made to master since this release, so can't we just use 1.4.1?

@jtojnar
Copy link
Contributor

jtojnar commented Oct 30, 2018

You should use phpst-unstable-yyyy-mm-dd, see the manual section on package naming.

@tmplt
Copy link
Member Author

tmplt commented Oct 30, 2018

@Synthetica9 v1.4.1 is built with tup, which expects a FUSE kernel module to be loaded; latest master is just raw Makefile.

@jtojnar Thanks; fixed.

@tmplt tmplt changed the title pbpst: init at 1.4.1+ecbe08a pbpst: init at unstable-2018-01-11 Oct 30, 2018
@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

@GrahamcOfBorg build pbpst

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pbpst

Partial log (click to expand)

install flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash install
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11
shrinking /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11/bin/pbpst
gzipping man pages under /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11/bin
patching script interpreter paths in /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11
checking for references to /build in /nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11...
/nix/store/pw06ijgwcis4p2lhg8fhh7lz11i7p5p5-pbpst-unstable-2018-01-11

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pbpst

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pbpst

Partial log (click to expand)

install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash install
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11
shrinking /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11/bin/pbpst
gzipping man pages under /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11/bin
patching script interpreter paths in /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11
checking for references to /build in /nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11...
/nix/store/c20p7c5f2f6bf6wlcsabf4f2sdqk122a-pbpst-unstable-2018-01-11

@xeji xeji merged commit 39662cf into NixOS:master Oct 30, 2018
@tmplt tmplt deleted the init-pbpst branch October 30, 2018 17:18
@tmplt tmplt mentioned this pull request Oct 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tmplt @Synthetica9 @jtojnar @xeji @GrahamcOfBorg