Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 3.5.3 -> 3.6.1 #49460

Merged
merged 1 commit into from Nov 1, 2018
Merged

platformio: 3.5.3 -> 3.6.1 #49460

merged 1 commit into from Nov 1, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I'll only get the chance to try this out properly on the weekend so not tested yet. It builds and runs but nothing more than pio --version and pio update has been attempted.

Cc: @makefu @mogorman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: platformio

Partial log (click to expand)

applying patch /nix/store/s8vy0rphkkg0qxrhh02las9w60s6fg6l-fix-searchpath.patch
patching file platformio/util.py
Hunk #1 succeeded at 431 with fuzz 1 (offset 36 lines).
updateAutotoolsGnuConfigScriptsPhase
configuring
building
copying path '/nix/store/am52jmd5gpnc0ykn7q1ywwrrpcwhi1v6-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/3f7g71flhmd0jlqbcjjmbn5nlp98v65w-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/dlx700d5hssg7x1a1zjhisr92km7pq1r-stdenv-linux' from 'https://cache.nixos.org'...
error: a 'i686-linux' is required to build '/nix/store/qri1rklf4i7a9iylqn3gzwafwpjhj1a9-python2.7-platformio-3.6.1.drv', but I am a 'aarch64-linux'

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: platformio

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
building '/nix/store/g3jfccdipf29nds1pxczqc2wrlfyvlbq-platformio-usr-multi.drv'...
created 936 symlinks in user environment
building '/nix/store/503pgg9lqxzs6g86iycq2cvwkfvv6s8w-platformio-fhs.drv'...
building '/nix/store/8r6kqgddj974h3mbjxa09hzqxmw9n7dw-platformio-init.drv'...
building '/nix/store/xyj28r7rpgl5l3dqnnsvi8jwmpgvfmgs-platformio.drv'...
/nix/store/7vvsy7445kh76r1g375qqq0s0qb8h2k5-platformio

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

The aarch64 error looks weird, and is a regression.

@makefu
Copy link
Contributor

makefu commented Oct 30, 2018

for better tracking we could also start the test environment as described in https://github.com/platformio/platformio-core/blob/develop/tox.ini#L62-L64 , or we explicitly disable the tests.

@peterhoeg
Copy link
Member Author

@xeji, are you sure this ever worked on aarch64?

@peterhoeg
Copy link
Member Author

for better tracking we could also start the test environment

@makefu, many of the tests require an internet connection. I have changed the PR to disable the tests that cannot pass in our sandbox.

@peterhoeg
Copy link
Member Author

Oh, and the pypi package doesn't contain the tests so we need to fetch from GH instead.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: platformio

Partial log (click to expand)

applying patch /nix/store/s8vy0rphkkg0qxrhh02las9w60s6fg6l-fix-searchpath.patch
patching file platformio/util.py
Hunk #1 succeeded at 431 with fuzz 1 (offset 36 lines).
updateAutotoolsGnuConfigScriptsPhase
configuring
building
copying path '/nix/store/am52jmd5gpnc0ykn7q1ywwrrpcwhi1v6-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/3f7g71flhmd0jlqbcjjmbn5nlp98v65w-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/dlx700d5hssg7x1a1zjhisr92km7pq1r-stdenv-linux' from 'https://cache.nixos.org'...
error: a 'i686-linux' is required to build '/nix/store/mwcajwiw41hh2d7sbrs232zcmna4is4w-python2.7-tox-3.2.1.drv', but I am a 'aarch64-linux'

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: platformio

Partial log (click to expand)

tests/commands/test_settings.py::test_settings_check PASSED              [100%]

============= 10 passed, 1 skipped, 27 deselected in 0.87 seconds ==============
pytestcachePhase
building '/nix/store/m1ppcrcm7iciih03ar8ymha36xqjrzqw-platformio-usr-multi.drv'...
created 936 symlinks in user environment
building '/nix/store/rd9yx6g26qyzp6b6m8h9cizs8fzdmgss-platformio-fhs.drv'...
building '/nix/store/pbq1rxns6jmjsm14f8kjx1j5mvybf3z6-platformio-init.drv'...
building '/nix/store/m90y2z0861rr6i9h0sngn1fdbxi61hjj-platformio.drv'...
/nix/store/9npan03nlab77nvbxjrr2qk2nmrxp0vc-platformio

@makefu
Copy link
Contributor

makefu commented Nov 1, 2018 •
edited

@peterhoeg wow, fantastic. Thanks for the effort! I think we should just disable aarch64 builds.
E.g.: meta.broken = stdenv.isAarch64;

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: platformio

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: platformio

Partial log (click to expand)

collision between `/nix/store/3v5r7fkrbkw2qajadvjbf6p6qriz9p1i-gcc-7.3.0-lib/lib/libgcc_s.so.1' and `/nix/store/7sdj151dlg1khkkqrycvs5jfp9i59ydp-glibc-multi-2.27/lib/libgcc_s.so.1'
collision between `/nix/store/vslcivmlk95wbib95zpizycg712rcfxl-shadow-4.6/etc/login.defs' and `/nix/store/3cbbzmfqlgry4q6pb0hbahkqhv1jc12r-platformio-chrootenv-etc/etc/login.defs'
collision between `/nix/store/vslcivmlk95wbib95zpizycg712rcfxl-shadow-4.6/etc/pam.d' and `/nix/store/3cbbzmfqlgry4q6pb0hbahkqhv1jc12r-platformio-chrootenv-etc/etc/pam.d'
created 1763 symlinks in user environment
building '/nix/store/m1ppcrcm7iciih03ar8ymha36xqjrzqw-platformio-usr-multi.drv'...
created 936 symlinks in user environment
building '/nix/store/rd9yx6g26qyzp6b6m8h9cizs8fzdmgss-platformio-fhs.drv'...
building '/nix/store/pbq1rxns6jmjsm14f8kjx1j5mvybf3z6-platformio-init.drv'...
building '/nix/store/m90y2z0861rr6i9h0sngn1fdbxi61hjj-platformio.drv'...
/nix/store/9npan03nlab77nvbxjrr2qk2nmrxp0vc-platformio

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

xeji, are you sure this ever worked on aarch64?

Not sure it works, but the current version builds on aarch64. I think disabling aarch64 is fine for now.

@peterhoeg peterhoeg merged commit 7b5a329 into NixOS:master Nov 1, 2018
@peterhoeg peterhoeg deleted the u/pio branch November 1, 2018 15:16
@alyssais alyssais mentioned this pull request Dec 11, 2018
Merged
10 tasks
@elohmeier elohmeier mentioned this pull request Jul 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @xeji @makefu