Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scuttlebot: add native build dependencies #49471

Merged
merged 1 commit into from Oct 31, 2018
Merged

scuttlebot: add native build dependencies #49471

merged 1 commit into from Oct 31, 2018

Conversation

patrl
Copy link
Contributor

@patrl patrl commented Oct 30, 2018

Motivation for this change

nodePackages.scuttlebot currently fails to build due to lack of native build dependencies, cc @cryptix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build nodePackages.scuttlebot

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

npm ERR! leveldown@3.0.2 install: `prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the leveldown@3.0.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/tmp/nix-build-node-scuttlebot-13.0.0.drv-0/.npm/_logs/2018-10-31T22_24_11_316Z-debug.log
builder for '/nix/store/288ynkc38bkc9fpy1lh250mdkp0am1qf-node-scuttlebot-13.0.0.drv' failed with exit code 1
error: build of '/nix/store/288ynkc38bkc9fpy1lh250mdkp0am1qf-node-scuttlebot-13.0.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

npm ERR! sodium-native@2.2.2 install: `node-gyp-build "node preinstall.js" "node postinstall.js"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the sodium-native@2.2.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2018-10-31T19_05_55_441Z-debug.log
builder for '/nix/store/j03m9vxzvyknamdggdjr9ypqx2zdms6c-node-scuttlebot-13.0.0.drv' failed with exit code 1
error: build of '/nix/store/j03m9vxzvyknamdggdjr9ypqx2zdms6c-node-scuttlebot-13.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/nnvhgikv2zjsnz4anym2gv7xrhw4racd-node-scuttlebot-13.0.0

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

Looks like some more build dependencies may be needed for darwin and aarch64, but they can be added later.

@xeji xeji merged commit 7c0122e into NixOS:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrl @xeji @GrahamcOfBorg