Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rstudioWrapper: include desktop file #49488

Merged
merged 1 commit into from Dec 10, 2018
Merged

rstudioWrapper: include desktop file #49488

merged 1 commit into from Dec 10, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 30, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from peti as a code owner October 30, 2018 20:36
@eadwu eadwu force-pushed the rstudioWrapper/add-desktop-file branch from b09f3a9 to 894239d Compare October 31, 2018 20:48
@eadwu eadwu force-pushed the rstudioWrapper/add-desktop-file branch from 894239d to a898f88 Compare December 7, 2018 21:45
@veprbl veprbl merged commit 86344b3 into NixOS:master Dec 10, 2018
@eadwu eadwu deleted the rstudioWrapper/add-desktop-file branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @Mic92 @veprbl @GrahamcOfBorg