Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Backport signal-desktop #49482

Merged
merged 8 commits into from Oct 30, 2018
Merged

[18.09] Backport signal-desktop #49482

merged 8 commits into from Oct 30, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 30, 2018

Motivation for this change

Reason: The current version (1.15.5) will expire soon (2018-11-14).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

primeos and others added 8 commits October 30, 2018 20:11
@primeos
signal-desktop: 1.15.5 -> 1.16.0
8558acb 
(cherry picked from commit 7c1b85c)
@primeos
signal-desktop: 1.16.0 -> 1.16.1
21e9b2e 
(cherry picked from commit 3410dcd)
@primeos
signal-desktop: 1.16.1 -> 1.16.2
2cbe9f9 
(cherry picked from commit a526719)
@tobiasBora @primeos
signal-desktop: enable notifications
73a1b48 
(cherry picked from commit 820e1ca)
@primeos
signal-desktop: 1.16.2 -> 1.16.3
18766e3 
(cherry picked from commit 5edc1dd)
@primeos
signal-desktop: 1.16.3 -> 1.17.0
95a7e49 
(cherry picked from commit f346289)
@primeos
signal-desktop: 1.17.0 -> 1.17.1
f3d906c 
(cherry picked from commit 6021a94)
@primeos
signal-desktop: 1.17.1 -> 1.17.2
ffebc0b 
(cherry picked from commit 46f5deb)
@primeos primeos added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 30, 2018
@primeos primeos self-assigned this Oct 30, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: signal-desktop

Partial log (click to expand)

trying https://updates.signal.org/desktop/apt/pool/main/s/signal-desktop/signal-desktop_1.17.2_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 68.8M  100 68.8M    0     0  15.6M      0  0:00:04  0:00:04 --:--:-- 15.6M
copying path '/nix/store/y1g7cvczk10q6bg9144xjrp9wkrn3l14-gtk+3-3.22.30' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/lfajnibl40y6kw1b1glcyn4hhvwg13vr-hook' from 'https://nix-cache.s3.amazonaws.com'...
building '/nix/store/74a5z4z73gq772sd4sbwg754ag5qq202-signal-desktop-1.17.2.drv'...
unpacking sources
installing
/nix/store/mpnlglim0jc54sda27h7d2mgai0ml2i7-signal-desktop-1.17.2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@primeos primeos merged commit 75836e7 into NixOS:release-18.09 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @GrahamcOfBorg @tobiasBora