Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-lib: Factor out shell completion scripts helper #49477

Merged
merged 1 commit into from Oct 30, 2018
Merged

haskell-lib: Factor out shell completion scripts helper #49477

merged 1 commit into from Oct 30, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Oct 30, 2018
Merged
9 tasks
@Ericson2314 Ericson2314 merged commit 26fa9d2 into NixOS:master Oct 30, 2018
@Ericson2314 Ericson2314 deleted the haskell-shell-completions branch October 30, 2018 19:33
@roberth roberth mentioned this pull request Nov 3, 2018
Closed
9 tasks
@roberth
Copy link
Member

roberth commented Nov 3, 2018

Looks like I'll have to rebase my solution on top of yours. Btw, thanks for all the fish! I suppose your fish line works, as opposed to mine 🐟

@Ericson2314
Copy link
Member Author

Oh sorry I didn't know about that PR.

This was referenced Nov 3, 2018
Merged
Closed
Ericson2314 pushed a commit to roberth/nixpkgs that referenced this pull request Nov 8, 2018
@roberth @Ericson2314
haskellPackages: Add shell completions + improve docs
2a1c0dd 
This adds the remaining parts of NixOS#42657 on top of NixOS#49477, renames the
function to a better name, and improves the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @roberth @GrahamcOfBorg