Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bamf: 0.5.3 -> 2018-02-07, fix build #49468

Merged
merged 1 commit into from Oct 30, 2018
Merged

bamf: 0.5.3 -> 2018-02-07, fix build #49468

merged 1 commit into from Oct 30, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Build failure.

For some reason this check would exit with

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/nix/store/cflsc3idxizgv0047hixkph5nsb3x85v-python-2.7.15-env/lib/python2.7/site-packages/libxslt.py", line 51, in <module>
    import libxml2mod
ImportError: No module named libxml2mod

when (python2.withPackages (pkgs: with pkgs; [ libxslt libxml2 ])) in nativeBuildInputs.

I've also synced the version to what's being used everywhere else.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@worldofpeace
bamf: 0.5.3 -> 2018-02-07, fix build
3358e25 
Technically this is 0.5.4 but it's unreleased
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bamf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/zfi6yp948jsw6m2ly1sicisyllsng3vn-bamf-2018-02-07-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zfi6yp948jsw6m2ly1sicisyllsng3vn-bamf-2018-02-07-dev/lib
patching script interpreter paths in /nix/store/zfi6yp948jsw6m2ly1sicisyllsng3vn-bamf-2018-02-07-dev
/nix/store/jfg6dy99a5s05brlyy46jvdw76x6cydd-bamf-2018-02-07
checking for references to /build in /nix/store/zfi6yp948jsw6m2ly1sicisyllsng3vn-bamf-2018-02-07-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/knaywcbmic30q1k5wki6py18lsknjv0g-bamf-2018-02-07-devdoc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/knaywcbmic30q1k5wki6py18lsknjv0g-bamf-2018-02-07-devdoc
checking for references to /build in /nix/store/knaywcbmic30q1k5wki6py18lsknjv0g-bamf-2018-02-07-devdoc...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bamf

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/7jnk5yg055p47z3b2670lp6sxywa1s75-bamf-2018-02-07-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7jnk5yg055p47z3b2670lp6sxywa1s75-bamf-2018-02-07-dev/lib
patching script interpreter paths in /nix/store/7jnk5yg055p47z3b2670lp6sxywa1s75-bamf-2018-02-07-dev
checking for references to /build in /nix/store/7jnk5yg055p47z3b2670lp6sxywa1s75-bamf-2018-02-07-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/z8572ssrvfivdnxdq4cvybkfjcfv2r2m-bamf-2018-02-07-devdoc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/z8572ssrvfivdnxdq4cvybkfjcfv2r2m-bamf-2018-02-07-devdoc
checking for references to /build in /nix/store/z8572ssrvfivdnxdq4cvybkfjcfv2r2m-bamf-2018-02-07-devdoc...
/nix/store/wbg947z698vzq62f107jzqpafs89igd8-bamf-2018-02-07

jtojnar
jtojnar reviewed Oct 30, 2018
View reviewed changes
pkgs/development/libraries/bamf/default.nix
# Tests
xorgserver
python2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does python3 not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

error: libxslt not supported for interpreter python3.6m

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we only fixed libxml2 :-/ #48609

pkgs/development/libraries/bamf/default.nix
autoconf
automake
docbook_xsl
gnome3.gnome-common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, this is some old build system: https://wiki.gnome.org/Projects/GnomeCommon/Migration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I should probably do that for them eventually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe port directly to meson ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that would be best 👍

@jtojnar jtojnar merged commit 92fcce4 into NixOS:master Oct 30, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Oct 30, 2018

Thanks for taking care of this.

@worldofpeace worldofpeace deleted the bamf-fix branch October 30, 2018 19:32
@worldofpeace
Copy link
Contributor Author

On to the next thing I go 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @jtojnar