Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-lib: Factor out shell completion scripts helper for 18.09 #49479

Merged
merged 1 commit into from Oct 30, 2018
Merged

haskell-lib: Factor out shell completion scripts helper for 18.09 #49479

merged 1 commit into from Oct 30, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #49477

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 merged commit 5fe3360 into NixOS:release-18.09 Oct 30, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Oct 30, 2018

Why is this eligible for backporting?

And git cherry-pick -x is missing.

@Ericson2314 Ericson2314 deleted the haskell-shell-completions branch October 30, 2018 19:33
@Ericson2314
Copy link
Member Author

Because it's harmless---I tested the one thing to test---and I need it on stable. Things are backported all the time because projects that use stable need something there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @dezgeg @GrahamcOfBorg