Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/libvirtd: utilize onShutdown option #49480

Merged
merged 1 commit into from Oct 30, 2018
Merged

nixos/libvirtd: utilize onShutdown option #49480

merged 1 commit into from Oct 30, 2018

Conversation

tmplt
Copy link
Member

@tmplt tmplt commented Oct 30, 2018

Motivation for this change

services.virtualisation.libvirtd.onShutdown was previously unused. While suspending a domain on host shutdown is the default, this commit makes it so domains can be shut down, also.

libvirt-guests.service runs ${pkgs.libvirt}/libexec/libvirt-guests.sh stop on host shutdown, which decides the appropriate on-shutdown action via ON_SHUTDOWN=${ON_SHUTDOWN:-suspend}.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tmplt
nixos/libvirtd: utilize onShutdown option
911b7da 
`services.virtualisation.libvirtd.onShutdown` was previously unused.
While suspending a domain on host shutdown is the default, this commit
makes it so domains can be shut down, also.
@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

Thank you for spotting and fixing this bug!

@xeji xeji merged commit a937dbe into NixOS:master Oct 30, 2018
@Profpatsch Profpatsch mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmplt @xeji @GrahamcOfBorg