Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add self as maintainer #49469

Merged
merged 5 commits into from Oct 30, 2018
Merged

Add self as maintainer #49469

merged 5 commits into from Oct 30, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Oct 30, 2018

Motivation for this change

I've been told that setting meta.maintainers on modules was a good thing so that people know who to poke. Here it is. I've also noticed while going through my PR history that I had forgotten to add myself as maintainer for global-platform-pro.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: global-platform-pro

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: global-platform-pro

Partial log (click to expand)

these paths will be fetched (31.86 MiB download, 103.81 MiB unpacked):
  /nix/store/jnhi8lcz37dpkjp7lfs2snabd8ih54da-openjdk-8u181b13-jre
  /nix/store/vw12vl2g3h7jgdxb7l2c9ghsqlhc3hss-global-platform-pro-18.09.14
copying path '/nix/store/jnhi8lcz37dpkjp7lfs2snabd8ih54da-openjdk-8u181b13-jre' from 'https://cache.nixos.org'...
copying path '/nix/store/vw12vl2g3h7jgdxb7l2c9ghsqlhc3hss-global-platform-pro-18.09.14' from 'https://cache.nixos.org'...
/nix/store/vw12vl2g3h7jgdxb7l2c9ghsqlhc3hss-global-platform-pro-18.09.14

@markuskowa markuskowa merged commit 1881e8e into NixOS:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @markuskowa