Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmusfm: init at 2018-10-11 #49467

Merged
merged 1 commit into from Nov 3, 2018
Merged

cmusfm: init at 2018-10-11 #49467

merged 1 commit into from Nov 3, 2018
+38 −0

Conversation

CharlesHD
Copy link
Contributor

Motivation for this change

This is a program wich allows scrobbling from cmus to the audioscrobbler API of Last.FM and Libre.FM. I use it to keep trace of my listening habits. It may help cmus users to scrobble their songs.

The configuration is explained in the meta.longDescription field and on the project repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar requested changes Oct 30, 2018
View reviewed changes
pkgs/applications/audio/cmusfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/cmusfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/cmusfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/cmusfm/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/cmusfm/default.nix Outdated Show resolved Hide resolved
@CharlesHD
Copy link
Contributor Author

Thanks for reviews. I think I applied all requested changes

@c0bw3b c0bw3b changed the title cmusfm: init at version ad2fd0aad3f4f1a25add1b8c2f179e8859885873 cmusfm: init at 2018-10-11 Oct 31, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2018

@GrahamcOfBorg build cmusfm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cmusfm

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11
shrinking /nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11/bin/cmusfm
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11/bin
patching script interpreter paths in /nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11
checking for references to /build in /nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11...
/nix/store/k8rvnj0r31cmiz64czj7hjsz5ri91rck-cmusfm-unstable-2018-10-11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cmusfm

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11
shrinking /nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11/bin/cmusfm
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11/bin
patching script interpreter paths in /nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11
checking for references to /build in /nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11...
/nix/store/haq6cf658xcjdva3hy2vy4rjfpbjsh51-cmusfm-unstable-2018-10-11

c0bw3b
c0bw3b approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c0bw3b c0bw3b merged commit 722fcbb into NixOS:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CharlesHD @c0bw3b @GrahamcOfBorg @jtojnar