lenovo/thinkpad/x230: add coreboot sub-profile #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
commented
Oct 30, 2018
|
|
||
| services.xserver.deviceSection = lib.mkDefault '' | ||
| Option "TearFree" "true" | ||
| ''; |
There was a problem hiding this comment.
This is gone as it's not specific to X230 config.
Mic92
reviewed
Oct 30, 2018
| @@ -0,0 +1,3 @@ | |||
| { | |||
| imports = [ ../common.nix ]; | |||
There was a problem hiding this comment.
should this variant be also added to the README?
|
Closed due lack of responsiveness. If someone else wants to add this profile, feel free to open it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACPI call is not supported by Coreboot, also it pulls in
mei_memodule which causes warnings if laptop runs on cleaned ME image (which, while orthogonal to Coreboot, typically goes hand in hand).