Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] net_snmp: fix CVE-2018-18065 #48125

Merged
merged 1 commit into from Oct 10, 2018
Merged

[18.09] net_snmp: fix CVE-2018-18065 #48125

merged 1 commit into from Oct 10, 2018

Conversation

andir
Copy link
Member

@andir andir commented Oct 9, 2018

Motivation for this change

This addresses a remote DoS attack (CVE-2018-18065).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
net_snmp: fix CVE-2018-18065
9bf0cd9 
(cherry picked from commit 2f7c242)
@andir andir changed the base branch from release-18.09 to staging-18.09 October 9, 2018 21:38
@andir andir requested a review from peti as a code owner October 9, 2018 21:44
@andir andir changed the base branch from staging-18.09 to release-18.09 October 9, 2018 21:45
@andir andir removed the request for review from peti October 9, 2018 21:45
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sbt, tinc, vdirsyncer

The following builds were skipped because they don't evaluate on x86_64-darwin: net_snmp, nixos-container

Partial log (click to expand)



error: aborting due to previous error

error: Could not compile `vdirsyncer-rustext`.

To learn more, run the command again with --verbose.
builder for '/nix/store/dwgkxizf17kmyl22abi0v5l1b4nldld1-vdirsyncer-0.17.0a3-native.drv' failed with exit code 101
cannot build derivation '/nix/store/bnhkihld6czaq1faw3d69sad06x5xi8z-vdirsyncer-0.17.0a3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bnhkihld6czaq1faw3d69sad06x5xi8z-vdirsyncer-0.17.0a3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: net_snmp, nixos-container, tinc, vdirsyncer

The following builds were skipped because they don't evaluate on aarch64-linux: sbt

Partial log (click to expand)

=========================== slowest 3 test durations ===========================
0.09s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VCARD]
0.06s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VTODO]
0.06s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VEVENT]
=================== 193 passed, 102 skipped in 2.58 seconds ====================
bash codecov.sh -c -F storage
/nix/store/gzvpmg53pc4flzbf0dkfwa5s7lb9xgl9-net-snmp-5.7.3
/nix/store/db9jg788mw9z111vvkcza9b6nvj5ph2n-nixos-container
/nix/store/grqc6jyg2zvvmhrqqb32xmcb69ybp5yk-tinc-1.0.35
/nix/store/dfabh0w3lkxfzpshj7c12aj25xlp9v72-vdirsyncer-0.17.0a3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: net_snmp

Partial log (click to expand)

/nix/store/gzvpmg53pc4flzbf0dkfwa5s7lb9xgl9-net-snmp-5.7.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: net_snmp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: net_snmp, nixos-container, tinc, vdirsyncer

The following builds were skipped because they don't evaluate on aarch64-linux: sbt

Partial log (click to expand)


b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/gzvpmg53pc4flzbf0dkfwa5s7lb9xgl9-net-snmp-5.7.3
/nix/store/db9jg788mw9z111vvkcza9b6nvj5ph2n-nixos-container
/nix/store/grqc6jyg2zvvmhrqqb32xmcb69ybp5yk-tinc-1.0.35
/nix/store/dfabh0w3lkxfzpshj7c12aj25xlp9v72-vdirsyncer-0.17.0a3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: net_snmp

Partial log (click to expand)

gzipping man pages under /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/lib  /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/bin  /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/sbin
patching script interpreter paths in /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/bin/net-snmp-config: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/bin/net-snmp-create-v3-user: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/bin/mib2c-update: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3...
moving /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/sbin/* to /nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3/bin
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sbt, tinc, vdirsyncer

The following builds were skipped because they don't evaluate on x86_64-darwin: net_snmp, nixos-container

Partial log (click to expand)



error: aborting due to previous error

error: Could not compile `vdirsyncer-rustext`.

To learn more, run the command again with --verbose.
builder for '/nix/store/dwgkxizf17kmyl22abi0v5l1b4nldld1-vdirsyncer-0.17.0a3-native.drv' failed with exit code 101
cannot build derivation '/nix/store/bnhkihld6czaq1faw3d69sad06x5xi8z-vdirsyncer-0.17.0a3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bnhkihld6czaq1faw3d69sad06x5xi8z-vdirsyncer-0.17.0a3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: net_snmp, nixos-container, sbt, tinc, vdirsyncer

Partial log (click to expand)

0.24s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VCARD]
0.19s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VTODO]
0.18s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VEVENT]
=================== 193 passed, 102 skipped in 3.69 seconds ====================
bash codecov.sh -c -F storage
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3
/nix/store/5ir05xp7nf25ajh68y4gsbnbsagy3y50-nixos-container
/nix/store/j3dzpr82l8j46s7s9cqhm61nrkrfnzhd-sbt-1.2.4
/nix/store/pj15a47s2wdza9appbh1hldn7jhas1j2-tinc-1.0.35
/nix/store/g5n04crz82f5a38g22wb3z6f82srf0rb-vdirsyncer-0.17.0a3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: net_snmp, nixos-container, sbt, tinc, vdirsyncer

Partial log (click to expand)

0.22s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VCARD]
0.16s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VTODO]
0.15s call     tests/storage/test_singlefile.py::TestSingleFileStorage::test_generic[VEVENT]
=================== 193 passed, 102 skipped in 3.35 seconds ====================
bash codecov.sh -c -F storage
/nix/store/csb4yrcpwsbvw58kzp3d9qxrlxym7c9z-net-snmp-5.7.3
/nix/store/5ir05xp7nf25ajh68y4gsbnbsagy3y50-nixos-container
/nix/store/j3dzpr82l8j46s7s9cqhm61nrkrfnzhd-sbt-1.2.4
/nix/store/pj15a47s2wdza9appbh1hldn7jhas1j2-tinc-1.0.35
/nix/store/g5n04crz82f5a38g22wb3z6f82srf0rb-vdirsyncer-0.17.0a3

@andir andir merged commit c7e72a7 into NixOS:release-18.09 Oct 10, 2018
@andir andir deleted the 18.09/net_snmp branch October 10, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg