Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midisheetmusic: add version to name #48109

Merged
merged 1 commit into from Oct 9, 2018
Merged

midisheetmusic: add version to name #48109

merged 1 commit into from Oct 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2018

Motivation for this change

Dang, I just noticed version is not part of name, that should be fixed.

Fixed, thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ghost ghost mentioned this pull request Oct 9, 2018
Merged
9 tasks
@joachifm joachifm merged commit 405a068 into NixOS:master Oct 9, 2018
@joachifm
Copy link
Contributor

joachifm commented Oct 9, 2018

Thanks for the quick fix.

@ghost ghost deleted the midisheetmusic branch October 10, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joachifm @GrahamcOfBorg