Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-contacts: fix compile failure due to clutter-gtk change #48135

Merged
merged 1 commit into from Oct 10, 2018
Merged

gnome3.gnome-contacts: fix compile failure due to clutter-gtk change #48135

merged 1 commit into from Oct 10, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

clutter-gtk moved to multiple outputs in 8abfa40, and gnome-contacts requires a workaround that references clutter's headers directly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Oct 10, 2018
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build gnome3.gnome-contacts

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.gnome-contacts

Partial log (click to expand)

Wrapping program /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/libexec/gnome-contacts-search-provider
shrinking RPATHs of ELF executables and libraries in /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2
shrinking /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/libexec/.gnome-contacts-search-provider-wrapped
shrinking /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/bin/.gnome-contacts-wrapped
gzipping man pages under /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/libexec  /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2/bin
patching script interpreter paths in /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2
checking for references to /build in /nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2...
/nix/store/2lm4pjib163aga8dz0qwwx39zkxjhl76-gnome-contacts-3.28.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.gnome-contacts

Partial log (click to expand)

Wrapping program /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/libexec/gnome-contacts-search-provider
shrinking RPATHs of ELF executables and libraries in /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2
shrinking /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/libexec/.gnome-contacts-search-provider-wrapped
shrinking /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/bin/.gnome-contacts-wrapped
gzipping man pages under /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/libexec  /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2/bin
patching script interpreter paths in /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2
checking for references to /build in /nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2...
/nix/store/yl6ajkzfdkw6g4a2bkbpysagczbpd21i-gnome-contacts-3.28.2

@xeji
Copy link
Contributor

xeji commented Oct 10, 2018

@GrahamcOfBorg test gnome3

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gnome3

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gnome3

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 783.20s
cleaning up
killing machine (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/20mx3lzsd93qkvwa0yq1qbpcpk2wzwcs-vm-test-run-gnome3

@xeji xeji merged commit 6a5a5b9 into NixOS:master Oct 10, 2018
@worldofpeace
Copy link
Contributor

@thefloweringash Thanks for the fix ❇️

@thefloweringash thefloweringash deleted the fix-clutter branch November 4, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thefloweringash @worldofpeace @GrahamcOfBorg @xeji @jtojnar