rmount: init at 1.0.1 #48120
rmount: init at 1.0.1 #48120
Conversation
|
Additionally, it may or may not be an issue, the git commit's author isn't properly linked to the github account; it could either be that you didn't add that e-mail address in your github account (not really an issue) or misconfigured git (maybe more of an issue). (The e-mail address used seems a bit... placeholder~ish.) |
|
Thank you very much for your help. I fixed every issue you described, the email was intentionally placeholder~ish but to eliminate conflicts, I just changed it to a real one. |
|
Should I close this Pull request and reopen a new one? |
|
Thanks! Now it's squashed and the minor things are fixed :-) |
GrahamcOfBorg
added
11.by: package-maintainer
and removed
2.status: merge conflict
labels
| stdenv.mkDerivation rec { | ||
| name = "rmount-${version}"; | ||
| version = "1.0.1"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Please move this declaration directly into the fetchFromGitHub call instead of calling inherit rev;
| { stdenv, nmap, jq, cifs-utils, sshfs, fetchFromGitHub, makeWrapper }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "rmount-${version}"; |
There was a problem hiding this comment.
Please change to pname = "rmount";
|
@luis-hebendanz in addition to the 2 requests I have made could you please rewrite the git history to contain 2 commits: the first simply adding yourself to the list of maintainers with an appropriate commit message, and the second commit adding the package? After these changes we'll get this merged right away. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)