Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdb: init at 0.75 #48114

Merged
merged 1 commit into from Oct 25, 2018
Merged

cdb: init at 0.75 #48114

merged 1 commit into from Oct 25, 2018

Conversation

Profpatsch
Copy link
Member

We check in the docs downloaded via wget, because upstream doesn’t
provide them.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

grahamc
grahamc previously requested changes Oct 15, 2018
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't be storing any upstream files like this in Nixpkgs. How does Debian package them?

@Profpatsch
Copy link
Member Author

Okay @grahamc, I’ve moved the docs into their own mirror repository.

@Profpatsch Profpatsch dismissed grahamc’s stale review October 25, 2018 18:13

removed the tarball

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cdb

Partial log (click to expand)

chmod 755 compile
( ( ./compile tryulong32.c && ./load tryulong32 && \
./tryulong32 ) >/dev/null 2>&1 \
&& cat uint32.h2 || cat uint32.h1 ) > uint32.h
rm -f tryulong32.o tryulong32
./compile cdbget.c
./compile: line 3: exec: gcc: not found
make: *** [Makefile:120: cdbget.o] Error 127
builder for '/nix/store/5y9b0h1cb49y1gh699f8fbz9gxzs4r39-cdb-0.75.drv' failed with exit code 2
error: build of '/nix/store/5y9b0h1cb49y1gh699f8fbz9gxzs4r39-cdb-0.75.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cdb

Partial log (click to expand)

checking for references to /build in /nix/store/2lpz70ll39ypjpj1j0bj1wwkag9k1wm2-cdb-0.75-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/2rmhlf69zas506ah41rdpcycp9jqjjzh-cdb-0.75-doc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2rmhlf69zas506ah41rdpcycp9jqjjzh-cdb-0.75-doc
checking for references to /build in /nix/store/2rmhlf69zas506ah41rdpcycp9jqjjzh-cdb-0.75-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/hs44vy8gmr2fnzn9zybrlvnv8vlhgxn6-cdb-0.75
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/hs44vy8gmr2fnzn9zybrlvnv8vlhgxn6-cdb-0.75
checking for references to /build in /nix/store/hs44vy8gmr2fnzn9zybrlvnv8vlhgxn6-cdb-0.75...
/nix/store/2lpz70ll39ypjpj1j0bj1wwkag9k1wm2-cdb-0.75-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cdb

Partial log (click to expand)

checking for references to /build in /nix/store/f18982nrnbrrigbf9crrjbwhpj4285y8-cdb-0.75-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/0hpjai507nsnv6m1xls6hk7zgfwg4rfw-cdb-0.75-doc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0hpjai507nsnv6m1xls6hk7zgfwg4rfw-cdb-0.75-doc
checking for references to /build in /nix/store/0hpjai507nsnv6m1xls6hk7zgfwg4rfw-cdb-0.75-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/k5b4dgwh3ymyv6n97vmifffilfh1sapl-cdb-0.75
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/k5b4dgwh3ymyv6n97vmifffilfh1sapl-cdb-0.75
checking for references to /build in /nix/store/k5b4dgwh3ymyv6n97vmifffilfh1sapl-cdb-0.75...
/nix/store/f18982nrnbrrigbf9crrjbwhpj4285y8-cdb-0.75-bin

@Profpatsch
cdb: init at 0.75
5c4ede2 
We check in the docs from a mirror repository, because the upstream
release doesn’t provide them.
@Profpatsch Profpatsch merged commit 2cc4200 into NixOS:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Profpatsch @GrahamcOfBorg @grahamc