Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus_2: 2.3.2 -> 2.4.3 #48118

Merged
merged 1 commit into from Oct 10, 2018
Merged

prometheus_2: 2.3.2 -> 2.4.3 #48118

merged 1 commit into from Oct 10, 2018

Conversation

sengaya
Copy link
Contributor

@sengaya sengaya commented Oct 9, 2018

Motivation for this change

https://github.com/prometheus/prometheus/releases/tag/v2.4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 9, 2018

@GrahamcOfBorg build prometheus_2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prometheus_2

Partial log (click to expand)

shrinking /nix/store/hk1amza8smd846gs5sdy2zmx9k0snr5m-prometheus-2.4.3-bin/bin/prometheus
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hk1amza8smd846gs5sdy2zmx9k0snr5m-prometheus-2.4.3-bin/bin
patching script interpreter paths in /nix/store/hk1amza8smd846gs5sdy2zmx9k0snr5m-prometheus-2.4.3-bin
checking for references to /build in /nix/store/hk1amza8smd846gs5sdy2zmx9k0snr5m-prometheus-2.4.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/p25qwdbv1hcc0qc4krxmxpw1r0i93h8v-prometheus-2.4.3
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/p25qwdbv1hcc0qc4krxmxpw1r0i93h8v-prometheus-2.4.3
checking for references to /build in /nix/store/p25qwdbv1hcc0qc4krxmxpw1r0i93h8v-prometheus-2.4.3...
/nix/store/hk1amza8smd846gs5sdy2zmx9k0snr5m-prometheus-2.4.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prometheus_2

Partial log (click to expand)

installing
post-installation fixup
Moving /nix/store/a1kclhyvcf1w5ls4cw5vf0xbcqll7iml-prometheus-2.4.3-bin/share/doc to /nix/store/31a9bq89bshkqnh3wiics241x8cdqms6-prometheus-2.4.3/share/doc
Removing empty /nix/store/a1kclhyvcf1w5ls4cw5vf0xbcqll7iml-prometheus-2.4.3-bin/share/ and (possibly) its parents
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a1kclhyvcf1w5ls4cw5vf0xbcqll7iml-prometheus-2.4.3-bin/bin
patching script interpreter paths in /nix/store/a1kclhyvcf1w5ls4cw5vf0xbcqll7iml-prometheus-2.4.3-bin
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/31a9bq89bshkqnh3wiics241x8cdqms6-prometheus-2.4.3
/nix/store/a1kclhyvcf1w5ls4cw5vf0xbcqll7iml-prometheus-2.4.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prometheus_2

Partial log (click to expand)

shrinking /nix/store/0gmhzriyzcxxhzzl7r2ipr2a8brylfri-prometheus-2.4.3-bin/bin/promtool
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0gmhzriyzcxxhzzl7r2ipr2a8brylfri-prometheus-2.4.3-bin/bin
patching script interpreter paths in /nix/store/0gmhzriyzcxxhzzl7r2ipr2a8brylfri-prometheus-2.4.3-bin
checking for references to /build in /nix/store/0gmhzriyzcxxhzzl7r2ipr2a8brylfri-prometheus-2.4.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/d3ij8g0ify3c6yb59r7lb7n3ibdjbfqp-prometheus-2.4.3
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/d3ij8g0ify3c6yb59r7lb7n3ibdjbfqp-prometheus-2.4.3
checking for references to /build in /nix/store/d3ij8g0ify3c6yb59r7lb7n3ibdjbfqp-prometheus-2.4.3...
/nix/store/0gmhzriyzcxxhzzl7r2ipr2a8brylfri-prometheus-2.4.3-bin

@xeji xeji merged commit adc6e9c into NixOS:master Oct 10, 2018
@sengaya sengaya deleted the prometheus-2.4.3 branch November 1, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sengaya @xeji @GrahamcOfBorg