Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grv: 0.2.0 -> 0.3.0 #49524

Merged
merged 1 commit into from Oct 31, 2018
Merged

grv: 0.2.0 -> 0.3.0 #49524

merged 1 commit into from Oct 31, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 31, 2018

Remove 'update_latest_release.go' so we don't try to build it
since this fails due to unmet dependencies.

AFAICT this utility is only meant for developer use anyway,
and helps manage/create new github releases for the project.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Oct 31, 2018

@GrahamcOfBorg build gitAndTools.grv

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin
shrinking /nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin/bin/grv
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin/bin
patching script interpreter paths in /nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin
checking for references to /build in /nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
/nix/store/82lsx3f6qj9cwz06jjjxyd6a7s8fyzvk-grv-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin
shrinking /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin/bin/grv
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin/bin
patching script interpreter paths in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin
checking for references to /build in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin

@andir
Copy link
Member

andir commented Oct 31, 2018

@dtzWill can you change the commit message to match the attribute name?

@dtzWill
gitAndTools.grv: 0.2.0 -> 0.3.0
8798de6 
Remove 'update_latest_release.go' so we don't try to build it
since this fails due to unmet dependencies.

AFAICT this utility is only meant for developer use anyway,
and helps manage/create new github releases for the project.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

/nix/store/igsqp5yafy43bdnq7zswgxglxiwzf8x2-grv-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
find: '/nix/store/q7wfa5xh2qqfkh1p0dqh2rxm8yfi8yvk-grv-0.3.0': No such file or directory
/nix/store/82lsx3f6qj9cwz06jjjxyd6a7s8fyzvk-grv-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.grv

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin
shrinking /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin/bin/grv
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin/bin
patching script interpreter paths in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin
checking for references to /build in /nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/h7m2nw96frg7ccsrkxz3azp4y2cj7kqc-grv-0.3.0-bin

@andir andir merged commit c5c2da9 into NixOS:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @andir @GrahamcOfBorg