Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kexpand: init at 2017-05-12 #49554

Merged
merged 1 commit into from Nov 9, 2018
Merged

kexpand: init at 2017-05-12 #49554

merged 1 commit into from Nov 9, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Oct 31, 2018 •
edited

Motivation for this change

Was requested in https://discourse.nixos.org/t/how-to-install-github-released-binary/1328

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b reviewed Nov 1, 2018
View reviewed changes
pkgs/development/tools/kexpand/default.nix Outdated
{ buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
name = "kexpand-2017-05-12";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "kexpand-2017-05-12";
name = "kexpand-unstable-2017-05-12";

https://nixos.org/nixpkgs/manual/#sec-package-naming

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 9, 2018

@GrahamcOfBorg build kexpand

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kexpand

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin
shrinking /nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin/bin/kexpand
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin/bin
patching script interpreter paths in /nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin
checking for references to /build in /nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/d5l8wgbc66z2glz1bsi13crkfhdwzc11-kexpand-unstable-2017-05-12-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kexpand

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin
shrinking /nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin/bin/kexpand
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin/bin
patching script interpreter paths in /nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin
checking for references to /build in /nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/pdlidjy7ifnxx7ipvy4b7nrh6mv1jv7d-kexpand-unstable-2017-05-12-bin

@c0bw3b c0bw3b merged commit 8c9a664 into NixOS:master Nov 9, 2018
@manveru manveru deleted the add-kexpand branch December 12, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @c0bw3b @GrahamcOfBorg