Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handbrake: 1.1.0 -> 1.1.2 #49551

Closed
wants to merge 1 commit into from
Closed

handbrake: 1.1.0 -> 1.1.2 #49551

wants to merge 1 commit into from
+2 −2

Conversation

grische
Copy link
Contributor

@grische grische commented Oct 31, 2018

fixed encoding issues and crashes

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (WSL)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

handbrake: 1.1.0 -> 1.1.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cb8e070 
fixed encoding issues and crashes
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 31, 2018
@roberth roberth added the 8.has: package (update) This PR updates a package to a newer version label Oct 31, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 1, 2018

@GrahamcOfBorg build handbrake

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: handbrake

Partial log (click to expand)

Wrapping program /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2/bin/ghb
Wrapping program /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2/bin/HandBrakeCLI
shrinking RPATHs of ELF executables and libraries in /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2
shrinking /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2/bin/.ghb-wrapped
shrinking /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2/bin/.HandBrakeCLI-wrapped
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2/bin
patching script interpreter paths in /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2
checking for references to /build in /nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2...
/nix/store/dyrxwwmmxfyp4x1w6zycpsaws6byglry-handbrake-1.1.2

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: handbrake

Partial log (click to expand)

mv -f .deps/hb-backend.Tpo .deps/hb-backend.Po
mv -f .deps/callbacks.Tpo .deps/callbacks.Po
make[3]: Leaving directory '/build/HandBrake-1.1.2/build/gtk/src'
make[2]: *** [Makefile:450: all-recursive] Error 1
make[2]: Leaving directory '/build/HandBrake-1.1.2/build/gtk'
make[1]: *** [Makefile:382: all] Error 2
make[1]: Leaving directory '/build/HandBrake-1.1.2/build/gtk'
make: *** [../gtk/module.rules:26: gtk.build] Error 2
builder for '/nix/store/xfnbv43gvpx3cqlrjcpa4zr5d6y4v0h3-handbrake-1.1.2.drv' failed with exit code 2
error: build of '/nix/store/xfnbv43gvpx3cqlrjcpa4zr5d6y4v0h3-handbrake-1.1.2.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 5, 2018

/cc maintainer @Anton-Latukha -> any idea as to why the build fails on aarch64 ?

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Nov 8, 2018 •
edited
Loading

@c0bw3b
In a couple of days I would do work on real aarch64 anyway, I would check what is with aarch64 build.

As I am maintainer, probably I should have portable aarch64-QEMU workflow.

Maybe https://hydra.nixos.org/job/nixpkgs/trunk/handbrake.aarch64-linux would also sync-up.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 8, 2018 •
edited
Loading

Well the ofBorg logs often gives enough information to start with.
And FYI there is a community ARMv8 build box: https://github.com/nix-community/aarch64-build-box
And there is an IRC chan #nixos-aarch64 (mentioned on https://nixos.wiki/wiki/Get_In_Touch )

Here in this instance it seems there is 2 errors:
gtkiconfactory.c:1035: Error: Gtk: encountered multiple return value parameters or tags for "gtk_icon_size_from_name".
and
app-indicator.c:482: Error: AppIndicator3: multiple "@arg1" parameters for identifier "AppIndicator::new-label":

@Mic92
Copy link
Member

Mic92 commented Nov 8, 2018

It would be acceptable also to disable aarch64 support for this package if we cannot maintain it.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 8, 2018

Probably yes.
I don't think many people are running heavy video transcoding jobs on small ARMv8 boards :p

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2018

Superseded by #50226
(the other PRs adds a bugfix and a test)

@c0bw3b c0bw3b closed this Nov 12, 2018
@grische grische deleted the handbrake_112 branch November 15, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@grische @c0bw3b @GrahamcOfBorg @Anton-Latukha @Mic92 @roberth