Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo: remove obsolete dependencies #49536

Closed
wants to merge 1 commit into from
Closed

hugo: remove obsolete dependencies #49536

wants to merge 1 commit into from

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Oct 31, 2018 •
edited

Motivation for this change

Hugo v0.50 was released 2 days ago. I also added myself to the maintainer list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

/cc @schneefux

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build hugo

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hugo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
shrinking /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin/hugo
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin
patching script interpreter paths in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
checking for references to /build in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: hugo

Partial log (click to expand)

cmd/compile/internal/gc.(*importReader).typ(0x400056f100, 0x40004a95c0)
        /nix/store/r2v4zhhdlgakyjj902lrykdzchwvahh6-go-1.11/share/go/src/cmd/compile/internal/gc/iimport.go:484 +0x30
cmd/compile/internal/gc.(*importReader).typ1(0x400056f100, 0x400056f100)
        /nix/store/r2v4zhhdlgakyjj902lrykdzchwvahh6-go-1.11/share/go/src/cmd/compile/internal/gc/iimport.go:544 +0x530
...additional frames elided...
github.com/gohugoio/hugo/hugofs
github.com/gohugoio/hugo/hugolib/filesystems
github.com/alecthomas/chroma/lexers/c
builder for '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed with exit code 59
error: build of '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hugo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
shrinking /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin/hugo
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin
patching script interpreter paths in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
checking for references to /build in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: hugo

Partial log (click to expand)

github.com/alecthomas/chroma/lexers/t
github.com/gohugoio/hugo/langs
github.com/gohugoio/hugo/hugolib/filesystems
github.com/alecthomas/chroma/lexers/d
github.com/alecthomas/chroma/lexers/c
github.com/alecthomas/chroma/lexers/h
github.com/alecthomas/chroma/lexers/s
github.com/gohugoio/hugo/transform/metainject
builder for '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed with exit code 50
error: build of '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed

@kalbasit
Copy link
Member Author

I looked at the failure on aarch64-linux, seems the compilation failed because it couldn't spawn more threads.

go tool compile: exit status 2
runtime: failed to create new OS thread (have 2 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

closing as duplicate of #49525.

@xeji xeji closed this Oct 31, 2018
@kalbasit kalbasit deleted the nixpkgs_update-hugo branch October 31, 2018 19:46
@kalbasit kalbasit restored the nixpkgs_update-hugo branch October 31, 2018 19:47
@kalbasit
Copy link
Member Author

@xeji #49525 does not seem to remove obsolete dependencies (see deps.nix in this PR), should I refile a PR to remove those dependencies?

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

Sorry, I didn't see that. I'll reopen this so you can just rebase this branch on current master and change the commit message. The remaining changes should be in deps.nix.

@xeji xeji reopened this Oct 31, 2018
@xeji xeji self-assigned this Oct 31, 2018
@kalbasit kalbasit requested a review from FRidh as a code owner October 31, 2018 20:04
@kalbasit kalbasit changed the title hugo: 0.49.2 -> 0.50 hugo: remove obsolete dependencies Oct 31, 2018
@kalbasit
Copy link
Member Author

@xeji done, please take another look.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hugo

Partial log (click to expand)

/nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: hugo

Partial log (click to expand)

github.com/alecthomas/chroma/lexers/t
github.com/alecthomas/chroma/lexers/w
github.com/alecthomas/chroma/lexers/x
github.com/alecthomas/chroma/lexers/y
github.com/alecthomas/chroma/lexers/r
github.com/alecthomas/chroma/lexers/c
github.com/alecthomas/chroma/lexers/h
github.com/alecthomas/chroma/lexers/s
builder for '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed with exit code 45
error: build of '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hugo

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
shrinking /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin/hugo
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin/bin
patching script interpreter paths in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin
checking for references to /build in /nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/3pn8yhqmj8jicrf9ng0ww9qyyc0260bk-hugo-0.50-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: hugo

Partial log (click to expand)

runtime.systemstack_switch()
        /nix/store/r2v4zhhdlgakyjj902lrykdzchwvahh6-go-1.11/share/go/src/runtime/asm_arm64.s:178 +0x8 fp=0x40000f4790 sp=0x40000f4780 pc=0x5f918
runtime.main()
        /nix/store/r2v4zhhdlgakyjj902lrykdzchwvahh6-go-1.11/share/go/src/runtime/proc.go:130 +0x54 fp=0x40000f47d0 sp=0x40000f4790 pc=0x39464
runtime.goexit()
        /nix/store/r2v4zhhdlgakyjj902lrykdzchwvahh6-go-1.11/share/go/src/runtime/asm_arm64.s:1114 +0x4 fp=0x40000f47d0 sp=0x40000f47d0 pc=0x61f34
github.com/gohugoio/hugo/hugolib/paths
github.com/gohugoio/hugo/hugolib/filesystems
builder for '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed with exit code 56
error: build of '/nix/store/5lwmcr1y2801hq9f985hc5lis3xixvxa-hugo-0.50.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

Thanks. Actually the current deps.nix (without this PR) seems to match the go.mod file in the source, while yours removes some unnecessary dependencies and modifies (probably updates, I didn't check) some revisions. I'm not really sure which is better. What do you think?

@kalbasit
Copy link
Member Author

if it matches go.mod, we should probably keep the upstream version in this case. Although I did test with mine and it seems to work fine.

@kalbasit
Copy link
Member Author

@xeji let me give https://github.com/adisbladis/vgo2nix a try and see what would it yield.

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

I just did that. It had some crashes due to not understanding replace directives but when I manually edited the go.mod, vgo2nix essentially provided the current deps.nix.
It's a great tool, but still in development.

@kalbasit
Copy link
Member Author

oh I see. In that case, let's let upstream deal with the dependencies. Closing this for now.

@kalbasit kalbasit closed this Oct 31, 2018
@kalbasit kalbasit deleted the nixpkgs_update-hugo branch October 31, 2018 22:02
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018 •
edited

Thank you! I think that go 1.11 modules will make packaging a lot easier if they are adopted, but they're still called an experimental feature...

@kalbasit
Copy link
Member Author

Definitely! I can't wait for it to go upstream. I think we can generate all of our go packages at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@xeji xeji

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @xeji