Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gplaycli: 3.21 -> 3.25 #49521

Merged
merged 1 commit into from Oct 31, 2018
Merged

python3Packages.gplaycli: 3.21 -> 3.25 #49521

merged 1 commit into from Oct 31, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 31, 2018 •
edited

Motivation for this change

The version 3.21 isn't compatible with our currently packaged
pythonPackages.gpapi which is now at version 0.4.3.

See https://hydra.nixos.org/build/83154918

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
python3Packages.gplaycli: 3.21 -> 3.25
01ae893 
The version 3.21 isn't compatible with our currently packaged
`pythonPackages.gpapi` which is now at version 0.4.3.

See https://hydra.nixos.org/build/83154918
@Ma27 Ma27 requested a review from FRidh as a code owner October 31, 2018 13:12
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build python36Packages.gplaycli

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.gplaycli

Partial log (click to expand)

reading manifest file 'GPlayCli.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/0qwpifl227fl01d9dlry8pbhagjppwmy-python3.6-gplaycli-3.25

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.gplaycli

Partial log (click to expand)

reading manifest file 'GPlayCli.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/cgdh29iflwqnhs5nrgw9wdcf4714gd8d-python3.6-gplaycli-3.25

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.gplaycli

Partial log (click to expand)

reading manifest file 'GPlayCli.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'GPlayCli.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/kyfc88x6b9jxczw897y6djm924cqq749-python3.6-gplaycli-3.25

@xeji xeji merged commit c6fc3bb into NixOS:master Oct 31, 2018
@Ma27 Ma27 deleted the fix-gplaycli branch October 31, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg